Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try #3 #5425

Closed
wants to merge 1 commit into from
Closed

try #3 #5425

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,15 @@
};
}

public getDerivedStateFromProps() {
console.log("getDerivedStateFromProps")

Check failure on line 168 in src/plugins/dashboard/public/application/embeddable/grid/dashboard_grid.tsx

View workflow job for this annotation

GitHub Actions / Build and Verify on Linux (ciGroup1)

Unexpected console statement

Check failure on line 168 in src/plugins/dashboard/public/application/embeddable/grid/dashboard_grid.tsx

View workflow job for this annotation

GitHub Actions / Build and Verify on Linux (ciGroup1)

Replace `"getDerivedStateFromProps")` with `'getDerivedStateFromProps');`

Check warning on line 168 in src/plugins/dashboard/public/application/embeddable/grid/dashboard_grid.tsx

View check run for this annotation

Codecov / codecov/patch

src/plugins/dashboard/public/application/embeddable/grid/dashboard_grid.tsx#L168

Added line #L168 was not covered by tests
if(this.state.panels!==this.props.container.getInput().panels){

Check failure on line 169 in src/plugins/dashboard/public/application/embeddable/grid/dashboard_grid.tsx

View workflow job for this annotation

GitHub Actions / Build and Verify on Linux (ciGroup1)

Replace `(this.state.panels!==this.props.container.getInput().panels)` with `·(this.state.panels·!==·this.props.container.getInput().panels)·`
console.log("here inside getDerivedStateFromProps if")

Check failure on line 170 in src/plugins/dashboard/public/application/embeddable/grid/dashboard_grid.tsx

View workflow job for this annotation

GitHub Actions / Build and Verify on Linux (ciGroup1)

Unexpected console statement

Check failure on line 170 in src/plugins/dashboard/public/application/embeddable/grid/dashboard_grid.tsx

View workflow job for this annotation

GitHub Actions / Build and Verify on Linux (ciGroup1)

Replace `"here·inside·getDerivedStateFromProps·if")` with `'here·inside·getDerivedStateFromProps·if');`

Check warning on line 170 in src/plugins/dashboard/public/application/embeddable/grid/dashboard_grid.tsx

View check run for this annotation

Codecov / codecov/patch

src/plugins/dashboard/public/application/embeddable/grid/dashboard_grid.tsx#L170

Added line #L170 was not covered by tests
//this.setState(this.props.container.getInput().panels as any)

Check failure on line 171 in src/plugins/dashboard/public/application/embeddable/grid/dashboard_grid.tsx

View workflow job for this annotation

GitHub Actions / Build and Verify on Linux (ciGroup1)

Expected exception block, space or tab after '//' in comment
return {panels: this.props.container.getInput().panels as any}

Check failure on line 172 in src/plugins/dashboard/public/application/embeddable/grid/dashboard_grid.tsx

View workflow job for this annotation

GitHub Actions / Build and Verify on Linux (ciGroup1)

Replace `panels:·this.props.container.getInput().panels·as·any}` with `·panels:·this.props.container.getInput().panels·as·any·};`

Check warning on line 172 in src/plugins/dashboard/public/application/embeddable/grid/dashboard_grid.tsx

View check run for this annotation

Codecov / codecov/patch

src/plugins/dashboard/public/application/embeddable/grid/dashboard_grid.tsx#L172

Added line #L172 was not covered by tests
}
}

public componentDidMount() {
this.mounted = true;
let isLayoutInvalid = false;
Expand Down Expand Up @@ -293,6 +302,7 @@
}

public render() {
console.log("render")

Check failure on line 305 in src/plugins/dashboard/public/application/embeddable/grid/dashboard_grid.tsx

View workflow job for this annotation

GitHub Actions / Build and Verify on Linux (ciGroup1)

Unexpected console statement

Check failure on line 305 in src/plugins/dashboard/public/application/embeddable/grid/dashboard_grid.tsx

View workflow job for this annotation

GitHub Actions / Build and Verify on Linux (ciGroup1)

Replace `"render")` with `'render');`
if (this.state.isLayoutInvalid) {
return null;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,12 @@
}

public render() {
if(!this.embeddable){

Check failure on line 89 in src/plugins/embeddable/public/lib/containers/embeddable_child_panel.tsx

View workflow job for this annotation

GitHub Actions / Build and Verify on Linux (ciGroup1)

Replace `(!this.embeddable)` with `·(!this.embeddable)·`
return null;
}
if(this.embeddable.parent && (this.embeddable.parent?.id !== this.props.container.id)){
return null;

Check warning on line 93 in src/plugins/embeddable/public/lib/containers/embeddable_child_panel.tsx

View check run for this annotation

Codecov / codecov/patch

src/plugins/embeddable/public/lib/containers/embeddable_child_panel.tsx#L93

Added line #L93 was not covered by tests
}
const { PanelComponent } = this.props;
const classes = classNames('embPanel', {
'embPanel-isLoading': this.state.loading,
Expand Down
Loading