Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try #3 #5425

Closed
wants to merge 1 commit into from
Closed

try #3 #5425

wants to merge 1 commit into from

Conversation

abbyhu2000
Copy link
Member

Description

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #5425 (5fd8a87) into main (eeb3251) will decrease coverage by 0.04%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #5425      +/-   ##
==========================================
- Coverage   66.83%   66.80%   -0.04%     
==========================================
  Files        3288     3288              
  Lines       63151    63160       +9     
  Branches    10054    10057       +3     
==========================================
- Hits        42206    42193      -13     
- Misses      18463    18482      +19     
- Partials     2482     2485       +3     
Flag Coverage Δ
Linux_1 ?
Linux_2 55.26% <ø> (ø)
Linux_3 43.82% <33.33%> (+<0.01%) ⬆️
Linux_4 35.34% <22.22%> (-0.01%) ⬇️
Windows_1 35.25% <0.00%> (-0.06%) ⬇️
Windows_2 55.22% <ø> (ø)
Windows_3 43.82% <33.33%> (-0.01%) ⬇️
Windows_4 35.34% <22.22%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...e/public/lib/containers/embeddable_child_panel.tsx 73.68% <50.00%> (-12.99%) ⬇️
...lic/application/embeddable/grid/dashboard_grid.tsx 69.01% <20.00%> (-3.72%) ⬇️

... and 4 files with indirect coverage changes

@kavilla kavilla closed this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants