Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add callout for both data explorer and legacy discover #4830

Closed
wants to merge 2 commits into from
+14 −2
Closed

Add callout for both data explorer and legacy discover #4830

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdc1e8f
add callout
abbyhu2000 Aug 26, 2023
5fbf858
change wording
abbyhu2000 Aug 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/plugins/discover/public/application/view_components/canvas/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/

import React, { useEffect, useState } from 'react';
import { EuiFlexGroup, EuiFlexItem, EuiPanel } from '@elastic/eui';
import { EuiFlexGroup, EuiFlexItem, EuiPanel, EuiCallOut } from '@elastic/eui';
import { TopNav } from './top_nav';
import { ViewProps } from '../../../../../data_explorer/public';
import { DiscoverTable } from './discover_table';
Expand Down Expand Up @@ -65,6 +65,12 @@ export default function DiscoverCanvas({ setHeaderActionMenu, history }: ViewPro
{status === ResultStatus.LOADING && <LoadingSpinner />}
{status === ResultStatus.READY && (
<>
<EuiFlexItem grow={false}>
<EuiCallOut
title="New Discover is available to switch by default and the old discover will be deprecated in 2.11."
iconType="alert"
/>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiPanel hasBorder={false} hasShadow={false} color="transparent" paddingSize="s">
<EuiPanel>
Expand Down
8 changes: 7 additions & 1 deletion src/plugins/discover_legacy/public/application/components/discover_legacy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@

import React, { useState, useCallback, useEffect } from 'react';
import classNames from 'classnames';
import { EuiButtonEmpty, EuiButtonIcon } from '@elastic/eui';
import { EuiButtonEmpty, EuiButtonIcon, EuiCallOut } from '@elastic/eui';
import { i18n } from '@osd/i18n';
import { FormattedMessage, I18nProvider } from '@osd/i18n/react';
import { IUiSettingsClient, MountPoint } from 'opensearch-dashboards/public';
Expand Down Expand Up @@ -218,6 +218,12 @@ export function DiscoverLegacy({
/>
</div>
<div className={`dscWrapper ${mainSectionClassName}`}>
<div>
<EuiCallOut
title="New Discover is available to switch by default and the old discover will be deprecated in 2.11."
iconType="alert"
/>
</div>
{resultState === 'none' && (
<DiscoverNoResults
timeFieldName={opts.timefield}
Expand Down
Loading