Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add callout for both data explorer and legacy discover #4830

Closed

Conversation

abbyhu2000
Copy link
Member

@abbyhu2000 abbyhu2000 commented Aug 26, 2023

Description

Add callout to inform users that legacy discover will be deprecated, and they can switch between data explorer and legacy discover.

Issues Resolved

Screenshot

Screenshot 2023-08-25 at 7 34 11 PM Screenshot 2023-08-25 at 7 34 28 PM

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@abbyhu2000 abbyhu2000 added ux / ui Improvements or additions to user experience, flows, components, UI elements discover for discover reinvent data explorer Issues related to the Data Explorer project labels Aug 26, 2023
@abbyhu2000 abbyhu2000 self-assigned this Aug 26, 2023
@abbyhu2000 abbyhu2000 added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Aug 26, 2023
Comment on lines 68 to 73
<div>
<EuiCallOut
title="New Discover is available to switch by default and the old discover will be deprecated in 2.11."
iconType="alert"
/>
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div>
<EuiCallOut
title="New Discover is available to switch by default and the old discover will be deprecated in 2.11."
iconType="alert"
/>
</div>
<EuiFlexItem grow={false}>
<EuiCallOut
title="New Discover is available to switch by default and the old discover will be deprecated in 2.11."
iconType="alert"
/>
</EuiFlexItem>

Does this work too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, verified and changed

@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Merging #4830 (5fbf858) into feature/data-explorer (521f306) will decrease coverage by 0.15%.
Report is 12 commits behind head on feature/data-explorer.
The diff coverage is 75.72%.

@@                    Coverage Diff                    @@
##           feature/data-explorer    #4830      +/-   ##
=========================================================
- Coverage                  66.50%   66.36%   -0.15%     
=========================================================
  Files                       3289     3390     +101     
  Lines                      62821    64729    +1908     
  Branches                    9788    10306     +518     
=========================================================
+ Hits                       41782    42959    +1177     
- Misses                     18658    19234     +576     
- Partials                    2381     2536     +155     
Flag Coverage Δ
Linux_1 34.91% <82.00%> (?)
Linux_2 55.13% <77.22%> (?)
Linux_3 43.97% <81.63%> (?)
Linux_4 35.10% <82.00%> (?)
Windows ?
Windows_1 34.92% <82.00%> (?)
Windows_2 55.10% <77.22%> (?)
Windows_3 43.97% <81.63%> (?)
Windows_4 35.11% <82.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/osd-babel-preset/node_preset.js 100.00% <ø> (ø)
...osd-opensearch-archiver/src/lib/docs/test_stubs.ts 68.75% <ø> (ø)
...ch-archiver/src/lib/indices/create_index_stream.ts 69.76% <ø> (ø)
...ch-archiver/src/lib/indices/delete_index_stream.ts 50.00% <ø> (ø)
...ver/src/lib/indices/opensearch_dashboards_index.ts 0.00% <0.00%> (ø)
packages/osd-pm/src/utils/package_json.ts 66.66% <ø> (ø)
packages/osd-ui-shared-deps/theme.ts 41.66% <0.00%> (ø)
src/core/public/chrome/chrome_service.mock.ts 100.00% <ø> (ø)
...c/core/public/chrome/ui/header/collapsible_nav.tsx 95.45% <ø> (+0.90%) ⬆️
src/core/public/chrome/ui/header/header.tsx 75.00% <ø> (+1.66%) ⬆️
... and 37 more

... and 320 files with indirect coverage changes

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
@ashwin-pc
Copy link
Member

Tagging @vagimeli cc: @mnkugler

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
@AMoo-Miki
Copy link
Collaborator

This will probably need OUI@1.3.0-beta.2 for verify.

@ashwin-pc
Copy link
Member

@abbyhu2000 can you update the PR with the new copy and raise this against main? Also you can test the dismiss function now that OUI 1.3 beta is merged to main

@abbyhu2000
Copy link
Member Author

Close this PR as #4857 contains the changes against main branch.

@abbyhu2000 abbyhu2000 closed this Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x data explorer Issues related to the Data Explorer project discover for discover reinvent distinguished-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry ux / ui Improvements or additions to user experience, flows, components, UI elements v2.10.0
Projects
Development

Successfully merging this pull request may close these issues.

4 participants