-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add callout for both data explorer and legacy discover #4830
Add callout for both data explorer and legacy discover #4830
Conversation
<div> | ||
<EuiCallOut | ||
title="New Discover is available to switch by default and the old discover will be deprecated in 2.11." | ||
iconType="alert" | ||
/> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<div> | |
<EuiCallOut | |
title="New Discover is available to switch by default and the old discover will be deprecated in 2.11." | |
iconType="alert" | |
/> | |
</div> | |
<EuiFlexItem grow={false}> | |
<EuiCallOut | |
title="New Discover is available to switch by default and the old discover will be deprecated in 2.11." | |
iconType="alert" | |
/> | |
</EuiFlexItem> |
Does this work too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, verified and changed
Codecov Report
@@ Coverage Diff @@
## feature/data-explorer #4830 +/- ##
=========================================================
- Coverage 66.50% 66.36% -0.15%
=========================================================
Files 3289 3390 +101
Lines 62821 64729 +1908
Branches 9788 10306 +518
=========================================================
+ Hits 41782 42959 +1177
- Misses 18658 19234 +576
- Partials 2381 2536 +155
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
This will probably need OUI@1.3.0-beta.2 for verify. |
@abbyhu2000 can you update the PR with the new copy and raise this against main? Also you can test the dismiss function now that OUI 1.3 beta is merged to main |
Close this PR as #4857 contains the changes against main branch. |
Description
Add callout to inform users that legacy discover will be deprecated, and they can switch between data explorer and legacy discover.
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr