Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [VisBuilder] [BUG] fix empty workspace animation does not work in firefox #2865

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 28c3df3 from #2853.

…efox (#2853)

* fix: fix VisBuilder empty animation does not work in firefox

Signed-off-by: raintygao <tygao@amazon.com>

* doc: add changelog for pull request

Signed-off-by: raintygao <tygao@amazon.com>

Signed-off-by: raintygao <tygao@amazon.com>
(cherry picked from commit 28c3df3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner November 11, 2022 20:14
@ashwin-pc
Copy link
Member

@AMoo-Miki @kavilla Do you know why the changelog is missing in the backport?

@codecov-commenter
Copy link

Codecov Report

Merging #2865 (fc79389) into 2.x (5926313) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              2.x    #2865   +/-   ##
=======================================
  Coverage   66.67%   66.68%           
=======================================
  Files        3219     3219           
  Lines       61445    61445           
  Branches     9417     9417           
=======================================
+ Hits        40968    40974    +6     
+ Misses      18231    18226    -5     
+ Partials     2246     2245    -1     
Impacted Files Coverage Δ
...uilder/public/application/components/workspace.tsx 4.00% <ø> (ø)
...ic/application/models/sense_editor/sense_editor.ts 64.88% <0.00%> (ø)
...ared/static/forms/hook_form_lib/hooks/use_field.ts 66.66% <0.00%> (+0.96%) ⬆️
packages/osd-optimizer/src/node/cache.ts 52.63% <0.00%> (+2.63%) ⬆️
...s/osd-optimizer/src/node/node_auto_tranpilation.ts 87.75% <0.00%> (+4.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ananzh
Copy link
Member

ananzh commented Nov 11, 2022

@AMoo-Miki @kavilla Do you know why the changelog is missing in the backport?

I think it is due to this PR: 8b30346

Currently, we are ignoring CHANGELOG. Once we release, we need to manually update CHANGELOG and create a release note.

@ashwin-pc
Copy link
Member

Oh no, I thought that the change ignored a conflict when creating the PR allowing us to fix it in the backport PR. This is worse. If this is the case, we should remove the changelog altogether until we have a better solution

@kavilla kavilla added v2.5.0 'Issues and PRs related to version v2.5.0' vis builder labels Nov 17, 2022
@kavilla kavilla merged commit e575cef into 2.x Nov 17, 2022
@github-actions github-actions bot deleted the backport/backport-2853-to-2.x branch November 17, 2022 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.5.0 'Issues and PRs related to version v2.5.0' vis builder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants