Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VisBuilder] [BUG] fix empty workspace animation does not work in firefox #2853

Merged
merged 2 commits into from
Nov 11, 2022

Conversation

raintygao
Copy link
Contributor

@raintygao raintygao commented Nov 10, 2022

Signed-off-by: raintygao tygao@amazon.com

Description

The visbuilder animation in firefox does not work.
This PR fixed the bug by modifying the dom structure and adding css attributes. Since osd-ui-shared will provide width: 100% style by default with a higher priority, !important is added to ensure that it meets expectations.

Normal condition:
image

Error condition
image

Issues Resolved

#2443

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: raintygao <tygao@amazon.com>
@raintygao raintygao requested a review from a team as a code owner November 10, 2022 07:54
@ashwin-pc
Copy link
Member

ashwin-pc commented Nov 11, 2022

Thanks for the additional context in the PR. The change looks good, i've validated it locally too. Can you add a changelog entry for the change too?

Signed-off-by: raintygao <tygao@amazon.com>
@codecov-commenter
Copy link

Codecov Report

Merging #2853 (b3b2beb) into main (4fd67de) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2853   +/-   ##
=======================================
  Coverage   66.67%   66.67%           
=======================================
  Files        3219     3219           
  Lines       61445    61445           
  Branches     9417     9417           
=======================================
  Hits        40966    40966           
  Misses      18232    18232           
  Partials     2247     2247           
Impacted Files Coverage Δ
...uilder/public/application/components/workspace.tsx 4.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Copy link
Member

@ananzh ananzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ashwin-pc ashwin-pc merged commit 28c3df3 into opensearch-project:main Nov 11, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 11, 2022
…efox (#2853)

* fix: fix VisBuilder empty animation does not work in firefox

Signed-off-by: raintygao <tygao@amazon.com>

* doc: add changelog for pull request

Signed-off-by: raintygao <tygao@amazon.com>

Signed-off-by: raintygao <tygao@amazon.com>
(cherry picked from commit 28c3df3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
sikhote pushed a commit to sikhote/OpenSearch-Dashboards that referenced this pull request Nov 14, 2022
…efox (opensearch-project#2853)

* fix: fix VisBuilder empty animation does not work in firefox

Signed-off-by: raintygao <tygao@amazon.com>

* doc: add changelog for pull request

Signed-off-by: raintygao <tygao@amazon.com>

Signed-off-by: raintygao <tygao@amazon.com>
Signed-off-by: David Sinclair <dsincla@rei.com>
kavilla pushed a commit that referenced this pull request Nov 17, 2022
…efox (#2853) (#2865)

* fix: fix VisBuilder empty animation does not work in firefox

Signed-off-by: raintygao <tygao@amazon.com>

* doc: add changelog for pull request

Signed-off-by: raintygao <tygao@amazon.com>

Signed-off-by: raintygao <tygao@amazon.com>
(cherry picked from commit 28c3df3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AlexRuiz7 pushed a commit to wazuh/wazuh-dashboard that referenced this pull request Dec 14, 2022
…efox (opensearch-project#2853)

* fix: fix VisBuilder empty animation does not work in firefox

Signed-off-by: raintygao <tygao@amazon.com>

* doc: add changelog for pull request

Signed-off-by: raintygao <tygao@amazon.com>

Signed-off-by: raintygao <tygao@amazon.com>
AlexRuiz7 pushed a commit to wazuh/wazuh-dashboard that referenced this pull request Dec 14, 2022
…efox (opensearch-project#2853)

* fix: fix VisBuilder empty animation does not work in firefox

Signed-off-by: raintygao <tygao@amazon.com>

* doc: add changelog for pull request

Signed-off-by: raintygao <tygao@amazon.com>

Signed-off-by: raintygao <tygao@amazon.com>
sipopo pushed a commit to sipopo/OpenSearch-Dashboards that referenced this pull request Dec 16, 2022
…efox (opensearch-project#2853)

* fix: fix VisBuilder empty animation does not work in firefox

Signed-off-by: raintygao <tygao@amazon.com>

* doc: add changelog for pull request

Signed-off-by: raintygao <tygao@amazon.com>

Signed-off-by: raintygao <tygao@amazon.com>
Signed-off-by: Sergey Osipov <sipopo@yandex.ru>
Arpit-Bandejiya pushed a commit to Arpit-Bandejiya/OpenSearch-Dashboards that referenced this pull request Jan 13, 2023
…efox (opensearch-project#2853)

* fix: fix VisBuilder empty animation does not work in firefox

Signed-off-by: raintygao <tygao@amazon.com>

* doc: add changelog for pull request

Signed-off-by: raintygao <tygao@amazon.com>

Signed-off-by: raintygao <tygao@amazon.com>
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
@joshuarrrr joshuarrrr added the v2.5.0 'Issues and PRs related to version v2.5.0' label Mar 10, 2023
sikhote pushed a commit to sikhote/OpenSearch-Dashboards that referenced this pull request Apr 24, 2023
…efox (opensearch-project#2853)

* fix: fix VisBuilder empty animation does not work in firefox

Signed-off-by: raintygao <tygao@amazon.com>

* doc: add changelog for pull request

Signed-off-by: raintygao <tygao@amazon.com>

Signed-off-by: raintygao <tygao@amazon.com>
Signed-off-by: David Sinclair <david@sinclair.tech>
sikhote pushed a commit to sikhote/OpenSearch-Dashboards that referenced this pull request Apr 24, 2023
…efox (opensearch-project#2853)

* fix: fix VisBuilder empty animation does not work in firefox

Signed-off-by: raintygao <tygao@amazon.com>

* doc: add changelog for pull request

Signed-off-by: raintygao <tygao@amazon.com>

Signed-off-by: raintygao <tygao@amazon.com>
Signed-off-by: David Sinclair <david@sinclair.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants