Dashboard Lists Integration #2670
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1483) * [Bug] fix copy as curl Copy as curl doesn't work in Dev Tools console due to usage of a deprecated method: https://developer.mozilla.org/en-US/docs/Web/API/Document/queryCommandSupported#browser_compatibility Issue Resolved: opensearch-project#1471 Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Adds browser compatibility comment Signed-off-by: Bishoy Boktor <boktorbb@amazon.com> Co-authored-by: Bishoy Boktor <boktorbb@amazon.com> (cherry picked from commit 376ba8c) Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
…ensearch-project#1490) * Addresses multiple CVEs. * CVE-2021-44531 (High) * CVE-2022-21824 (High) * CVE-2022-0778 (High) * CVE-2021-44532 (Medium) * CVE-2021-44533 (Medium) * [CHANGELOG](https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V14.md#2022-03-17-version-14191-fermium-lts-richardlau) Follow-up from opensearch-project#920 Signed-off-by: Tommy Markley <markleyt@amazon.com> (cherry picked from commit e0f394e)
…project#1525) Signed-off-by: Anan Zhuang <ananzh@amazon.com> fix PR comments Signed-off-by: Anan Zhuang <ananzh@amazon.com> add CVE details and emoji Signed-off-by: Anan Zhuang <ananzh@amazon.com> make node-14 to CVE Signed-off-by: Anan Zhuang <ananzh@amazon.com> remove UI lib from breaking changes. correct deprecations and maintanence Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Anan <79961084+ananzh@users.noreply.github.com> (cherry picked from commit 9ab752a) Co-authored-by: Anan <79961084+ananzh@users.noreply.github.com>
…ct#1542) * This workflow is unnecessary now that the org uses the DCO App. Signed-off-by: Tommy Markley <markleyt@amazon.com>
…1543) https://opensearch.org/docs/2.0/ is now available. Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
…oject#1521) Bumps [ejs](https://github.com/mde/ejs) from 3.1.6 to 3.1.7. - [Release notes](https://github.com/mde/ejs/releases) - [Changelog](https://github.com/mde/ejs/blob/main/CHANGELOG.md) - [Commits](mde/ejs@v3.1.6...v3.1.7) Resolves opensearch-project#1501 - CVE-2022-29078 --- updated-dependencies: - dependency-name: ejs dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 886f3e3)
…pensearch-project#1531) - fix typo in iconType for `replace_panel` action - change iconType types from `string` to `EuiIconType` - use `icon` instead of `iconType` for svg pathseslin - remove unnecessary icon assertions Resolves opensearch-project#1475 Signed-off-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit ef3a9c0)
…-project#1552) (opensearch-project#1557) * Addresses CVE-2022-1214 * Bumps and resolves `axios` to ^0.27.2 to address CVE * [CHANGELOG](https://github.com/axios/axios/blob/master/CHANGELOG.md) * Bumps `chromedriver` to v100 to match GitHub actions Signed-off-by: Bishoy Boktor <boktorbb@amazon.com> (cherry picked from commit cba0764)
…ensearch-project#1565) add back icon directive, which injects SVG Signed-off-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit bd10227)
… (opensearch-project#1577) Signed-off-by: Tommy Markley <markleyt@amazon.com> (cherry picked from commit 2a96761)
…roject#1585) Addresses CVE-2022-1537 Issue: opensearch-project#1579 Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit 1792662)
…arch-project#1559) (opensearch-project#1591) * Utilizes Codecov yaml configuration: https://docs.codecov.com/docs/codecov-yaml * The purpose of enforcing increasing code coverage over time is to attempt to improve the quality of changes via testing, reduce the need to request tests in PRs, and stay away from enforcing an ambiguous coverage percentage. Signed-off-by: Tommy Markley <markleyt@amazon.com> (cherry picked from commit 21d7b6f)
…) (opensearch-project#1596) * Adds a missed CVE fix. * Re-categorizes the chromedriver bump. * Removes a PR follow-up for the memory circuit breaker change. Signed-off-by: Tommy Markley <markleyt@amazon.com> (cherry picked from commit c74c1f5) Co-authored-by: Tommy Markley <markleyt@amazon.com>
…t#1598) (opensearch-project#1604) There is currently to a PR to remove the v7 and v8 (beta) theme versions within the application but it is getting stale: opensearch-project#978 Since the v8 (beta) theme isn't actually planned and has the incorrect version, we do not want end users to be able to change this setting. In the essence of time, this will prevent this setting from showing in the Advanced Settings page but will also not break users who set this version already (however it will lock them into theme until they switched by manually updating or deleting the config doc). Removing this setting will force the default to be v8 (beta). Temporary fix for: opensearch-project#494 But it should be removed completely. Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit 87e5412) Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
…1599) (opensearch-project#1606) Resolves opensearch-project#1594 Signed-off-by: Tommy Markley <markleyt@amazon.com> (cherry picked from commit 8bc8d14)
…#1626) (opensearch-project#1628) package.json and yarn.lock already updated to 100.0.0 Signed-off-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit 665424e) Co-authored-by: Josh Romero <rmerqg@amazon.com>
…earch-project#1649) (opensearch-project#1657) Signed-off-by: manasvis <manasvis@amazon.com> (cherry picked from commit 115deda) Co-authored-by: Manasvini B Suryanarayana <105884062+manasvinibs@users.noreply.github.com>
…roject#1624) (opensearch-project#1659) (opensearch-project#1675) [CI][BWC] add BWC tests to github actions (opensearch-project#1624) Add backwards compatibility tests to github workflow for PRs. Also, fix for checking status of OpenSearch Dashboards since api/status/ is not protected. Also, enable ability to create test data since migration from 1.0.0 to 3.0.0 is not supported for OpenSearch currently. Issue: opensearch-project#1465 opensearch-project#1651 Backport PR: opensearch-project#1624 Includes changes from: opensearch-project#1502 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
…project#1672) Add container width to enable correct truncation Normalize line height to prevent clipped descenders Fixes opensearch-project#1643 Signed-off-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit b888cca) Co-authored-by: Josh Romero <rmerqg@amazon.com>
…project#1570) (opensearch-project#1666) Signed-off-by: Rafael Vargas <rafaelflvargas@gmail.com> (cherry picked from commit dea9ea0) Co-authored-by: Rafael Vargas <vargas.rafael9@gmail.com>
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
…ct#1550) (opensearch-project#1707) * Fix WMS can't load when unable access maps services Signed-off-by: Junqiu Lei <junqiu@amazon.com> (cherry picked from commit b2cfb6e)
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
) (opensearch-project#1774) Incorrectly set the date range of the library. This sets the value correctly and turns the dates into consts. Issue: n/a Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit 4703abf) Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
…ch-project#2107) Issue: opensearch-project#1873 This was happening because of a prop useDefaultGroupDomain. This prop was introduced into the elastic charts to allow clustering for the multiple series which will share a common Y domain i.e for example the stacked and non- stacked bars will have the same Y common domain/axis. As per the elastic/charts whenever the useDefaultGroupDomain is set to true, it will force to group the series/visualiations groupId's to a default group domain. But, TSVB is not a shared Y domain. So the prop is unneeded. Further insight: From the code: ``` const groupId = hasSeparateAxis || isStackedWithinSeries ? seriesGroup.id : mainAxisGroupId; ``` where ``` const mainAxisGroupId = yAxisIdGenerator('main_group'); ``` ... which indicates that the global default `groupId` is not used by TSVB. Hence, TSVB should have not been using `useDefaultGroupDomain` ever. Signed-off-by: AbhishekReddy1127 <nallamsa@amazon.com> (cherry picked from commit 55181d4) Co-authored-by: Abhishek Reddy <62020972+AbhishekReddy1127@users.noreply.github.com>
…ns (opensearch-project#1946) (opensearch-project#1959) Resolves issue - opensearch-project#1895 Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com> (cherry picked from commit 2c428b8) Co-authored-by: Manasvini B Suryanarayana <manasvis@amazon.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
…-project#2244) Enable filtering with custom health checks based on node attributes: ``` opensearch.optimizedHealthcheck.filters: { attribute_key: "attribute_value", } ``` Also, fixes issue that expects the response to array when it was a dictionary. Issue: opensearch-project#2214 opensearch-project#2203 Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit e6bbb40) Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
…ch-project#2277) (opensearch-project#2298) Original implementation incorrectly assumed the return list of nodes was an object array. This PR: opensearch-project#2232 Addressed the return but didn't catch the nodes.find in the return which is a function for an array. Also, refactors to return a list of node_ids because the original implementation indicated that it should but it can return node ids but it never did. It only returned `null` or `_local`, the problem with this approach is that it doesn't expect valid node version with different DIs or filter out nodes when we pass `null` as the node ID for the node info call because it was fan out the request to all nodes. Now this function will return `_local` if all the nodes share the same cluster_id using a greedy approach since we can assume it is all the same version. Will return node ids, if the cluster_id are different so it will pass a CSV to the node info call and return the info for those nodes. And null if no cluster_id is present, ie, fan out the response. Original issue: opensearch-project#2203 Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Ran npx browserslist@latest --update-db to update caniuse package so the integration tests will pass Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> (cherry picked from commit 9c73047) Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
…ch-project#1948) (opensearch-project#1955) (opensearch-project#2388) Issue: n/a Backport PRs will also run actions for pushs and PRs which is just unneeded double work everytime. So this prevents that. Also, BWC will run a complete array for every job in the matrix. Now we set the environment variable to prevents the running of the default versions. Finally updating date range of filter tests to be more inclusive for new test data. Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit 57a751e) (cherry picked from commit dfe13d6) Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
…roject#1823) (opensearch-project#2387) Maps zoom level were updated to be 14 as noted here: opensearch-project/maps#4 (comment) Issue: n/a Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit e7362f9) Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
…pensearch-project#2366) ### Description Updates `moment-timezone` Dependabot PR: opensearch-project#2229 ### Issues Resolved opensearch-project#2262 opensearch-project#2263 Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> (cherry picked from commit 77b6068) Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
…search-project#2352) (opensearch-project#2371) * Pass `options` to `vega.parse` to enable inclusion of parsed ASTs * Introduce the forced CSP-compliant interpreter that prevents evaluation of unsafe methods * Modified the consumed `leaflet-vega` package to one that honors `options` Signed-off-by: Miki <miki@amazon.com> Signed-off-by: Miki <miki@amazon.com> (cherry picked from commit bebbcca) Co-authored-by: Miki <miki@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
* Configure types for registration of Dashboard List "Providers" and "Creators" * Add Left-Nav "top-level" category for Observability Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com>
Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com>
7 tasks
|
@pjfitzgibbons It looks like this PR needs some snapshot and test updates. |
|
Also @pjfitzgibbons can you create an issue in OSD for this PR that outlines the issue and why this change is necessary in Dashboards. While I and a few other may have context on how the observability feature links to this PR, its still useful to know exactly what the gap in OSD is to support your use case and what are the possible solutions you looked at as context for this change. |
|
|
Oops, my bad. I thought it was referencing an issue on the observability repo. Thanks! |
pjfitzgibbons
changed the title
pjfitzgibbons
changed the title
|
Need to rebase to branch 2.x. Too much churn. PR recreated as #2980 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Configure types for registration of Dashboard List "Providers" and "Creators"
Add Left-Nav "top-level" category for Observability
These changes enable the interactions demonstrated in this animation:
Issues WIP
[FEATURE] Dashboards List Extensibility & Integrate Observability Apps/Panels/EventAnalytics
Related PR
[Feature] Observability - Dashboard Lists Integration opensearch-project/observability#1180
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr