-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI][BWC] add BWC tests to github actions #1624
[CI][BWC] add BWC tests to github actions #1624
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1624 +/- ##
=======================================
Coverage 68.08% 68.09%
=======================================
Files 3072 3072
Lines 59015 59015
Branches 8924 8924
=======================================
+ Hits 40183 40187 +4
+ Misses 16645 16642 -3
+ Partials 2187 2186 -1
Continue to review full report at Codecov.
|
a9aeea6
to
b0e4018
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, except that I think the instructions/docs could be a bit clearer. I'm still a bit confused about how the process of generating test data is supposed to work/be enforced.
Do we also need an update to https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/RELEASING.md, if generating test data should be done as part of a release? Or maybe just an update to the release issue templates.
b0e4018
to
7008596
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice 👍
77c74ef
to
1a0becc
Compare
Add backwards compatibility tests to github workflow for PRs. Also, fix for checking status of OpenSearch Dashboards since api/status/ is not protected. Also, enable ability to create test data since migration from 1.0.0 to 3.0.0 is not supported for OpenSearch currently. Issue: opensearch-project#1465 opensearch-project#1651 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
aea6e2f
to
a30510e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple questions, but none that are blocking.
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
fe30eac
to
6af85d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great research & cool piece
Add backwards compatibility tests to github workflow for PRs. Also, fix for checking status of OpenSearch Dashboards since api/status/ is not protected. Also, enable ability to create test data since migration from 1.0.0 to 3.0.0 is not supported for OpenSearch currently. Issue: opensearch-project#1465 opensearch-project#1651 Backport PR: opensearch-project#1624 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Add backwards compatibility tests to github workflow for PRs. Also, fix for checking status of OpenSearch Dashboards since api/status/ is not protected. Also, enable ability to create test data since migration from 1.0.0 to 3.0.0 is not supported for OpenSearch currently. Issue: opensearch-project#1465 opensearch-project#1651 Backport PR: opensearch-project#1624 Includes changes from: opensearch-project#1502 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Add backwards compatibility tests to github workflow for PRs. Also, fix for checking status of OpenSearch Dashboards since api/status/ is not protected. Also, enable ability to create test data since migration from 1.0.0 to 3.0.0 is not supported for OpenSearch currently. Issue: opensearch-project#1465 opensearch-project#1651 Backport PR: opensearch-project#1624 Includes changes from: opensearch-project#1502 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
* [CI][BWC] add BWC tests to github actions (#1624) Add backwards compatibility tests to github workflow for PRs. Also, fix for checking status of OpenSearch Dashboards since api/status/ is not protected. Also, enable ability to create test data since migration from 1.0.0 to 3.0.0 is not supported for OpenSearch currently. Issue: #1465 #1651 Backport PR: #1624 Includes changes from: #1502 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
…roject#1624) (opensearch-project#1659) [CI][BWC] add BWC tests to github actions (opensearch-project#1624) Add backwards compatibility tests to github workflow for PRs. Also, fix for checking status of OpenSearch Dashboards since api/status/ is not protected. Also, enable ability to create test data since migration from 1.0.0 to 3.0.0 is not supported for OpenSearch currently. Issue: opensearch-project#1465 opensearch-project#1651 Backport PR: opensearch-project#1624 Includes changes from: opensearch-project#1502 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
… (#1675) [CI][BWC] add BWC tests to github actions (#1624) Add backwards compatibility tests to github workflow for PRs. Also, fix for checking status of OpenSearch Dashboards since api/status/ is not protected. Also, enable ability to create test data since migration from 1.0.0 to 3.0.0 is not supported for OpenSearch currently. Issue: #1465 #1651 Backport PR: #1624 Includes changes from: #1502 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
* [CI][BWC] add BWC tests to github actions Add backwards compatibility tests to github workflow for PRs. Also, fix for checking status of OpenSearch Dashboards since api/status/ is not protected. Also, enable ability to create test data since migration from 1.0.0 to 3.0.0 is not supported for OpenSearch currently. Issue: opensearch-project#1465 opensearch-project#1651 Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Address comments Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
* [CI][BWC] add BWC tests to github actions Add backwards compatibility tests to github workflow for PRs. Also, fix for checking status of OpenSearch Dashboards since api/status/ is not protected. Also, enable ability to create test data since migration from 1.0.0 to 3.0.0 is not supported for OpenSearch currently. Issue: opensearch-project#1465 opensearch-project#1651 Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Address comments Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Changes originating from: opensearch-project#1624 This allows the workflow to run using the published images from: https://hub.docker.com/r/opensearchstaging/ci-runner/tags. To avoid the issues when GitHub virtual environments are updated. Issue: opensearch-project#1746 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
* [CI][BWC] add BWC tests to github actions Add backwards compatibility tests to github workflow for PRs. Also, fix for checking status of OpenSearch Dashboards since api/status/ is not protected. Also, enable ability to create test data since migration from 1.0.0 to 3.0.0 is not supported for OpenSearch currently. Issue: opensearch-project#1465 opensearch-project#1651 Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Address comments Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
…roject#1624) (opensearch-project#1659) * [CI][BWC] add BWC tests to github actions (opensearch-project#1624) Add backwards compatibility tests to github workflow for PRs. Also, fix for checking status of OpenSearch Dashboards since api/status/ is not protected. Also, enable ability to create test data since migration from 1.0.0 to 3.0.0 is not supported for OpenSearch currently. Issue: opensearch-project#1465 opensearch-project#1651 Backport PR: opensearch-project#1624 Includes changes from: opensearch-project#1502 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Description
Add backwards compatibility tests to github workflow for PRs.
Also, fix for checking status of OpenSearch Dashboards since
api/status/ is not protected.
Also, enable ability to create test data since migration from
1.0.0 to 3.0.0 is not supported for OpenSearch currently.
Signed-off-by: Kawika Avilla kavilla414@gmail.com
Issues Resolved
#1465
#1651
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr