[Backport 1.3] [BUG] Plugin helpers fix related to fs promises module #2487
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
In Node v10, there was no dedicated module for fs/promises. Causing the plugin helpers to fail while building out plugins. Solved by importing promises from fs then using the desired methods. Issue Resolved: #2485 Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit 945cfe6)
kavilla
approved these changes
Oct 3, 2022
joshuarrrr
approved these changes
Oct 3, 2022
|
Unit tests pass locally as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 945cfe6 from #2486