-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG][1.3] Plugin build fails with Error: Cannot find module 'fs/promises'
#2485
Comments
kavilla
added a commit
to kavilla/OpenSearch-Dashboards-1
that referenced
this issue
Oct 3, 2022
In Node v10, there was no dedicated module for fs/promises. Causing the plugin helpers to fail while building out plugins. Solved by importing promises from fs then using the desired methods. Issue Resolved: opensearch-project#2485 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
8 tasks
kavilla
added a commit
to kavilla/OpenSearch-Dashboards-1
that referenced
this issue
Oct 3, 2022
In Node v10, there was no dedicated module for fs/promises. Causing the plugin helpers to fail while building out plugins. Solved by importing promises from fs then using the desired methods. Issue Resolved: opensearch-project#2485 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
8 tasks
kavilla
added a commit
that referenced
this issue
Oct 3, 2022
In Node v10, there was no dedicated module for fs/promises. Causing the plugin helpers to fail while building out plugins. Solved by importing promises from fs then using the desired methods. Issue Resolved: #2485 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this issue
Oct 3, 2022
In Node v10, there was no dedicated module for fs/promises. Causing the plugin helpers to fail while building out plugins. Solved by importing promises from fs then using the desired methods. Issue Resolved: #2485 Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit 945cfe6)
kavilla
pushed a commit
that referenced
this issue
Oct 3, 2022
In Node v10, there was no dedicated module for fs/promises. Causing the plugin helpers to fail while building out plugins. Solved by importing promises from fs then using the desired methods. Issue Resolved: #2485 Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit 945cfe6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
A clear and concise description of what the bug is.
opensearch-project/sql#881 (comment)
To Reproduce
Steps to reproduce the behavior:
plugins
dir (tried security dashboards and query workbench)yarn osd bootstrap && yarn build
Expected behavior
Should not fail
OpenSearch Version
1.3.6
Dashboards Version
1.3.6
Plugins
Please list all plugins currently enabled.
Screenshots
If applicable, add screenshots to help explain your problem.
Host/Environment (please complete the following information):
Additional context
After reverting 9195654 (#2475),
yarn build
works againThe text was updated successfully, but these errors were encountered: