Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] [Data Explorer] Discover rendering wrong when index pattern is removed and click refresh #5159

Closed
ananzh opened this issue Sep 29, 2023 · 0 comments · Fixed by #5160
Closed

[BUG] [Data Explorer] Discover rendering wrong when index pattern is removed and click refresh #5159

ananzh opened this issue Sep 29, 2023 · 0 comments · Fixed by #5160
Assignees
@ananzh
Labels
bug Something isn't working data explorer Issues related to the Data Explorer project de-angular de-angularize work discover for discover reinvent v2.11.0

Comments

@ananzh
Copy link
Member

ananzh commented Sep 29, 2023

To Reproduce
Steps to reproduce the behavior:

  1. Add a sample data, then click Discover to use sample data index
  2. Open another page and go to Home --> add data. Remove the previously added sample data.
  3. Click the previously opened Discover page. Click refresh.
  4. See Discover is not updated.

Expected behavior
Screenshot 2023-09-29 at 15 06 29
@ananzh ananzh added bug Something isn't working discover for discover reinvent data explorer Issues related to the Data Explorer project v2.11.0 labels Sep 29, 2023
@ananzh ananzh self-assigned this Sep 29, 2023
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Sep 29, 2023
@ananzh
[BUG][Discover] Add onQuerySubmit to top nav and allow force update t…
a99aea0 
…o embeddable

* all reload to force update embeddable
* add onQuerySubmit to top nav

Issue Resolve
opensearch-project#5116
opensearch-project#5159

Signed-off-by: ananzh <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Sep 29, 2023
@ananzh
[BUG][Discover] Add onQuerySubmit to top nav and allow force update t…
22683d0 
…o embeddable

* all reload to force update embeddable
* add onQuerySubmit to top nav

Issue Resolve
opensearch-project#5116
opensearch-project#5159

Signed-off-by: ananzh <ananzh@amazon.com>
@ananzh ananzh mentioned this issue Sep 29, 2023
Merged
8 tasks
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Sep 29, 2023
@ananzh
[BUG][Discover] Add onQuerySubmit to top nav and allow force update t…
fd76b5a 
…o embeddable

* all reload to force update embeddable
* add onQuerySubmit to top nav

Issue Resolve
opensearch-project#5116
opensearch-project#5159

Signed-off-by: ananzh <ananzh@amazon.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Sep 29, 2023
@ananzh
[BUG][Discover] Add onQuerySubmit to top nav and allow force update t…
5d2f1ca 
…o embeddable

* all reload to force update embeddable
* add onQuerySubmit to top nav

Issue Resolve
opensearch-project#5116
opensearch-project#5159

Signed-off-by: ananzh <ananzh@amazon.com>
@ananzh ananzh removed the untriaged label Sep 29, 2023
@ashwin-pc ashwin-pc added the de-angular de-angularize work label Oct 2, 2023
joshuarrrr pushed a commit that referenced this issue Oct 3, 2023
@ananzh @AMoo-Miki @ashwin-pc
[BUG][Discover] Add onQuerySubmit to top nav and allow force update t…
7d89cca 
…o embeddable (#5160)

* all reload to force update embeddable
* add onQuerySubmit to top nav

Issue Resolve
#5116
#5159

Signed-off-by: ananzh <ananzh@amazon.com>
Co-authored-by: Miki <miki@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
Leo7Deng pushed a commit to Leo7Deng/OpenSearch-Dashboards that referenced this issue Oct 4, 2023
@ananzh @AMoo-Miki
@ashwin-pc @Leo7Deng
[BUG][Discover] Add onQuerySubmit to top nav and allow force update t…
1e93ed4 
…o embeddable (opensearch-project#5160)

* all reload to force update embeddable
* add onQuerySubmit to top nav

Issue Resolve
opensearch-project#5116
opensearch-project#5159

Signed-off-by: ananzh <ananzh@amazon.com>
Co-authored-by: Miki <miki@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Leo Deng <leo7deng@gmail.com>
ananzh added a commit to ananzh/OpenSearch-Dashboards that referenced this issue Oct 4, 2023
@ananzh @AMoo-Miki @ashwin-pc
[Manual backport 2.x][BUG][Discover] Add onQuerySubmit to top nav and…
eabd083 
… allow force update to embeddable (opensearch-project#5160)

* all reload to force update embeddable
* add onQuerySubmit to top nav

Backport PR
opensearch-project#5160

Issue Resolve
opensearch-project#5116
opensearch-project#5159

Signed-off-by: ananzh <ananzh@amazon.com>
Co-authored-by: Miki <miki@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
@ananzh ananzh mentioned this issue Oct 4, 2023
Closed
8 tasks
AMoo-Miki added a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Oct 4, 2023
@ananzh @AMoo-Miki @ashwin-pc
[BUG][Discover] Add onQuerySubmit to top nav and allow force update t…
abed99a 
…o embeddable (opensearch-project#5160)

* all reload to force update embeddable
* add onQuerySubmit to top nav

Issue Resolve
opensearch-project#5116
opensearch-project#5159

Signed-off-by: ananzh <ananzh@amazon.com>
Co-authored-by: Miki <miki@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>

(cherry picked from commit 7d89cca)
Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki added a commit that referenced this issue Oct 4, 2023
@AMoo-Miki @ananzh @ashwin-pc
[Manual 2.x] De-angular backports collection (#5219)
6d9f4ae 
* [BUG][Discover] Add onQuerySubmit to top nav and allow force update to embeddable (#5160)

* all reload to force update embeddable
* add onQuerySubmit to top nav

Issue Resolve
#5116
#5159

Signed-off-by: ananzh <ananzh@amazon.com>
Co-authored-by: Miki <miki@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>

(cherry picked from commit 7d89cca)
Signed-off-by: Miki <miki@amazon.com>

* [Discover] A bunch of navigation fixes (#5168)

* Discover: Fixes state persistence after nav
* Fixed breadcrumbs and navigation
* fixes mobile view

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

(cherry picked from commit cb6e0f0)
Signed-off-by: Miki <miki@amazon.com>

* [BUG][Data Explorer][Discover] Automatically load solo added default index pattern (#5171)

* [BUG][Data Explorer][Discover] Automatically load solo added default index pattern

This fix ensures that when add a default index pattern, Discover will
automatically select and load its details.

Issue Resolve
#5128

---------

Signed-off-by: ananzh <ananzh@amazon.com>

(cherry picked from commit 9601c6c)
Signed-off-by: Miki <miki@amazon.com>

* [BUG][Data Explorer][Discover] Allow data grid to auto adjust size based on fetched data count (#5191)

* This PR adds a new rows state to the DiscoverCanvas component and updated it whenever
the data$ observable emitted new row data.
* The DiscoverTable component was then refactored to accept rows as a prop, making it
dependent on the parent component to provide the correct set of data. This ensures that the table
renders correctly based on the current data and doesn't rely on its internal state,
which could be outdated.

Issue Resolve
#5181

Signed-off-by: ananzh <ananzh@amazon.com>

(cherry picked from commit 677fdf5)
Signed-off-by: Miki <miki@amazon.com>

* Fixes mobile layout (#5195)

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
(cherry picked from commit 0ffd2ab)

* [BUG][Data Explorer][Discover] Allow filter and query persist when refresh page or paste url to a new tab (#5206)

Issue Resolve
#5179
#5071

Signed-off-by: ananzh <ananzh@amazon.com>

(cherry picked from commit 5623cef)
Signed-off-by: Miki <miki@amazon.com>

* fixes DataTable rendering in doscover (#5207)

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
(cherry picked from commit c70125f)

---------

Signed-off-by: ananzh <ananzh@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
willie-hung pushed a commit to willie-hung/OpenSearch-Dashboards that referenced this issue Oct 5, 2023
@ananzh @AMoo-Miki
@ashwin-pc @willie-hung
[BUG][Discover] Add onQuerySubmit to top nav and allow force update t…
a46c4a7 
…o embeddable (opensearch-project#5160)

* all reload to force update embeddable
* add onQuerySubmit to top nav

Issue Resolve
opensearch-project#5116
opensearch-project#5159

Signed-off-by: ananzh <ananzh@amazon.com>
Co-authored-by: Miki <miki@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Willie Hung <willie880201044@gmail.com>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this issue Oct 7, 2023
@ananzh @AMoo-Miki
@ashwin-pc @SuZhou-Joe
[BUG][Discover] Add onQuerySubmit to top nav and allow force update t…
516e1f7 
…o embeddable (opensearch-project#5160)

* all reload to force update embeddable
* add onQuerySubmit to top nav

Issue Resolve
opensearch-project#5116
opensearch-project#5159

Signed-off-by: ananzh <ananzh@amazon.com>
Co-authored-by: Miki <miki@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ananzh ananzh

Labels
bug Something isn't working data explorer Issues related to the Data Explorer project de-angular de-angularize work discover for discover reinvent v2.11.0
Projects
None yet
Milestone
No milestone
2 participants
@ashwin-pc @ananzh