Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Manual backport 2.x][BUG][Discover] Add onQuerySubmit to top nav and allow force update to embeddable (#5160) #5218

Closed
wants to merge 1 commit into from
Closed

[Manual backport 2.x][BUG][Discover] Add onQuerySubmit to top nav and allow force update to embeddable (#5160) #5218

wants to merge 1 commit into from

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Oct 4, 2023

Description

  • all reload to force update embeddable
  • add onQuerySubmit to top nav

Backport PR

#5160

Issue Resolve

#5116 #5159

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@ananzh @AMoo-Miki @ashwin-pc
[Manual backport 2.x][BUG][Discover] Add onQuerySubmit to top nav and…
eabd083 
… allow force update to embeddable (opensearch-project#5160)

* all reload to force update embeddable
* add onQuerySubmit to top nav

Backport PR
opensearch-project#5160

Issue Resolve
opensearch-project#5116
opensearch-project#5159

Signed-off-by: ananzh <ananzh@amazon.com>
Co-authored-by: Miki <miki@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
@ananzh ananzh added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.11.0 de-angular de-angularize work bug Something isn't working labels Oct 4, 2023
@ananzh
Copy link
Member Author

ananzh commented Oct 4, 2023

close this due to combine backport.

@ananzh ananzh closed this Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@seanneumann seanneumann Awaiting requested review from seanneumann

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@kristenTian kristenTian Awaiting requested review from kristenTian

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@BSFishy BSFishy Awaiting requested review from BSFishy

Assignees
No one assigned
Labels
bug Something isn't working de-angular de-angularize work Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ananzh