[Workspace] Fix non-workspace admin update defaultIndex (#8675) (#8679)

* Fix updating defaultIndex at workspace uiSetting level



* Changeset file for PR #8675 created/updated

* optimize the code



* optimize the code



* optimize the code



---------



(cherry picked from commit 41ab14d)

Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

changelogs/fragments/8675.yml

@@ -0,0 +1,2 @@
+fix:
+- [Workspace] Fix non-workspace admin update defaultIndex ([#8675](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8675))

src/core/public/workspace/types.ts

@@ -5,7 +5,7 @@
 
 import { WorkspaceAttribute } from '../../types';
 
-export type WorkspaceObject = WorkspaceAttribute & { readonly?: boolean };
+export type WorkspaceObject = WorkspaceAttribute & { readonly?: boolean; owner?: boolean };
 
 export type IWorkspaceResponse<T> =
   | {

src/plugins/data/common/index_patterns/index_patterns/ensure_default_index_pattern.ts

@@ -36,13 +36,17 @@ export type EnsureDefaultIndexPattern = () => Promise<unknown | void> | undefine
 
 export const createEnsureDefaultIndexPattern = (
   uiSettings: UiSettingsCommon,
-  onRedirectNoIndexPattern: () => Promise<unknown> | void
+  onRedirectNoIndexPattern: () => Promise<unknown> | void,
+  canUpdateUiSetting?: boolean
 ) => {
   /**
    * Checks whether a default index pattern is set and exists and defines
    * one otherwise.
    */
   return async function ensureDefaultIndexPattern(this: IndexPatternsContract) {
+    if (canUpdateUiSetting === false) {
+      return;
+    }
     const patterns = await this.getIds();
     let defaultId = await uiSettings.get('defaultIndex');
     let defined = !!defaultId;

src/plugins/data/common/index_patterns/index_patterns/index_patterns.ts

@@ -74,6 +74,7 @@ interface IndexPatternsServiceDeps {
   onError: OnError;
   onRedirectNoIndexPattern?: () => void;
   onUnsupportedTimePattern: OnUnsupportedTimePattern;
+  canUpdateUiSetting?: boolean;
 }
 
 export class IndexPatternsService {
@@ -96,6 +97,7 @@ export class IndexPatternsService {
     onError,
     onUnsupportedTimePattern,
     onRedirectNoIndexPattern = () => {},
+    canUpdateUiSetting,
   }: IndexPatternsServiceDeps) {
     this.apiClient = apiClient;
     this.config = uiSettings;
@@ -106,7 +108,8 @@ export class IndexPatternsService {
     this.onUnsupportedTimePattern = onUnsupportedTimePattern;
     this.ensureDefaultIndexPattern = createEnsureDefaultIndexPattern(
       uiSettings,
-      onRedirectNoIndexPattern
+      onRedirectNoIndexPattern,
+      canUpdateUiSetting
     );
   }
 

src/plugins/data/public/plugin.ts

@@ -193,7 +193,15 @@ export class DataPublicPlugin
   }
 
   public start(core: CoreStart, { uiActions }: DataStartDependencies): DataPublicPluginStart {
-    const { uiSettings, http, notifications, savedObjects, overlays, application } = core;
+    const {
+      uiSettings,
+      http,
+      notifications,
+      savedObjects,
+      overlays,
+      application,
+      workspaces,
+    } = core;
     setNotifications(notifications);
     setOverlays(overlays);
     setUiSettings(uiSettings);
@@ -220,6 +228,12 @@ export class DataPublicPlugin
         notifications.toasts,
         application.navigateToApp
       ),
+      // If workspace is enabled, only workspace owner/OSD admin can update ui setting.
+      ...(application.capabilities.workspaces.enabled && {
+        canUpdateUiSetting:
+          workspaces?.currentWorkspace$.getValue()?.owner ||
+          application.capabilities?.dashboards?.isDashboardAdmin !== false,
+      }),
     });
     setIndexPatterns(indexPatterns);
 

src/plugins/workspace/public/workspace_client.test.ts

@@ -178,6 +178,7 @@ describe('#WorkspaceClient', () => {
     expect(workspaceMock.workspaceList$.getValue()).toEqual([
       {
         id: 'foo',
+        owner: true,
         readonly: false,
       },
     ]);

src/plugins/workspace/public/workspace_client.ts

@@ -113,17 +113,27 @@ export class WorkspaceClient implements IWorkspaceClient {
     });
 
     if (result?.success) {
-      const resultWithWritePermission = await this.list({
-        perPage: 999,
-        permissionModes: [WorkspacePermissionMode.LibraryWrite],
-      });
-      if (resultWithWritePermission?.success) {
+      const [resultWithWritePermission, resultWithOwnerPermission] = await Promise.all([
+        this.list({
+          perPage: 999,
+          permissionModes: [WorkspacePermissionMode.LibraryWrite],
+        }),
+        this.list({
+          perPage: 999,
+          permissionModes: [WorkspacePermissionMode.Write],
+        }),
+      ]);
+      if (resultWithWritePermission?.success && resultWithOwnerPermission?.success) {
         const workspaceIdsWithWritePermission = resultWithWritePermission.result.workspaces.map(
           (workspace: WorkspaceAttribute) => workspace.id
         );
+        const workspaceIdsWithOwnerPermission = resultWithOwnerPermission.result.workspaces.map(
+          (workspace: WorkspaceAttribute) => workspace.id
+        );
         const workspaces = result.result.workspaces.map((workspace: WorkspaceAttribute) => ({
           ...workspace,
           readonly: !workspaceIdsWithWritePermission.includes(workspace.id),
+          owner: workspaceIdsWithOwnerPermission.includes(workspace.id),
         }));
         this.workspaces.workspaceList$.next(workspaces);
       }