[Workspace] Fix non-workspace admin update defaultIndex #8675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yubonluo <yubonluo@amazon.com>
yubonluo
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
SuZhou-Joe
reviewed
Oct 22, 2024
src/plugins/data/common/index_patterns/index_patterns/ensure_default_index_pattern.ts
Outdated
Show resolved
Hide resolved
SuZhou-Joe
reviewed
Oct 22, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8675 +/- ##
==========================================
- Coverage 60.86% 60.85% -0.01%
==========================================
Files 3793 3793
Lines 90381 90387 +6
Branches 14185 14188 +3
==========================================
Hits 55006 55006
- Misses 31898 31903 +5
- Partials 3477 3478 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: yubonluo <yubonluo@amazon.com>
Hailong-am
reviewed
Oct 22, 2024
SuZhou-Joe
reviewed
Oct 22, 2024
Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
Hailong-am
approved these changes
Oct 22, 2024
ruanyl
approved these changes
Oct 22, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 22, 2024
* Fix updating defaultIndex at workspace uiSetting level Signed-off-by: yubonluo <yubonluo@amazon.com> * Changeset file for PR #8675 created/updated * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> --------- Signed-off-by: yubonluo <yubonluo@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 41ab14d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl
pushed a commit
that referenced
this pull request
Oct 23, 2024
* Fix updating defaultIndex at workspace uiSetting level * Changeset file for PR #8675 created/updated * optimize the code * optimize the code * optimize the code --------- (cherry picked from commit 41ab14d) Signed-off-by: yubonluo <yubonluo@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When no workspace user navigate to Maps/Visualization page, the defaultIndex will be updated and show the error toast.
After fixing, no workspace admin will not update default index.
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration