Skip to content

Commit

Permalink
iio: dac: ti-dac7311: Make use of the helper function dev_err_probe()
Browse files Browse the repository at this point in the history
When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Link: https://lore.kernel.org/r/20210928013902.1341-8-caihuoqing@baidu.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
  • Loading branch information
caihuoqing1990 authored and jic23 committed Oct 19, 2021
1 parent 7051c12 commit d1249ba
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions drivers/iio/dac/ti-dac7311.c
Original file line number Diff line number Diff line change
Expand Up @@ -266,10 +266,9 @@ static int ti_dac_probe(struct spi_device *spi)
ti_dac->resolution = spec->resolution;

ti_dac->vref = devm_regulator_get(dev, "vref");
if (IS_ERR(ti_dac->vref)) {
dev_err(dev, "error to get regulator\n");
return PTR_ERR(ti_dac->vref);
}
if (IS_ERR(ti_dac->vref))
return dev_err_probe(dev, PTR_ERR(ti_dac->vref),
"error to get regulator\n");

ret = regulator_enable(ti_dac->vref);
if (ret < 0) {
Expand Down

0 comments on commit d1249ba

Please sign in to comment.