Skip to content

Commit

Permalink
iio: dac: stm32-dac: Make use of the helper function dev_err_probe()
Browse files Browse the repository at this point in the history
When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Link: https://lore.kernel.org/r/20210928013902.1341-7-caihuoqing@baidu.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
  • Loading branch information
caihuoqing1990 authored and jic23 committed Oct 19, 2021
1 parent c0e9ef0 commit 7051c12
Showing 1 changed file with 4 additions and 10 deletions.
14 changes: 4 additions & 10 deletions drivers/iio/dac/stm32-dac-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -116,18 +116,12 @@ static int stm32_dac_probe(struct platform_device *pdev)
priv->common.regmap = regmap;

priv->pclk = devm_clk_get(dev, "pclk");
if (IS_ERR(priv->pclk)) {
ret = PTR_ERR(priv->pclk);
dev_err(dev, "pclk get failed\n");
return ret;
}
if (IS_ERR(priv->pclk))
return dev_err_probe(dev, PTR_ERR(priv->pclk), "pclk get failed\n");

priv->vref = devm_regulator_get(dev, "vref");
if (IS_ERR(priv->vref)) {
ret = PTR_ERR(priv->vref);
dev_err(dev, "vref get failed, %d\n", ret);
return ret;
}
if (IS_ERR(priv->vref))
return dev_err_probe(dev, PTR_ERR(priv->vref), "vref get failed\n");

pm_runtime_get_noresume(dev);
pm_runtime_set_active(dev);
Expand Down

0 comments on commit 7051c12

Please sign in to comment.