EqualsAvoidsNull should flip arguments for constants

[Pankraz76]

Hi,

I might have found an issue in my local project where around 90 violations flagged by PMD are not being replaced correctly. Some of these violations seem related to a list and method arguments.

Could you please take over and enable the necessary tests to confirm if this is indeed an issue?

Thanks in advance!

@timtebeek
@knutwannheden
@ggerbaud

[github-actions]

Some suggestions could not be made:

• src/main/java/org/openrewrite/staticanalysis/EqualsAvoidsNullVisitor.java
  • lines 18-18

[timtebeek]

Thanks for the help here @punkratz312 ! Nice to see these cases covered as well.

[Pankraz76]

wow so quick 🥇 well done 🍀

[Pankraz76]

this is wrong imho

[timtebeek]

Ah sorry to hear; in which way? What kind of changes would you propose we make now?

[Pankraz76]

Addressing references is tricky and not covered by other projects like PMD and Checkstyle. Implementing this breaks the idempotency, causing: #472

Changing a reference with another reference makes no sense to me, which is this feature kind of about.
Its like fixing one leak by taking from another one thats not leaking ATM. We just flip for infinity as we can not truly determine which one is null, only by changing the arguments (a reference with another reference).

[Pankraz76]

Addressing references is tricky and not covered by other projects like PMD and Checkstyle. Implementing this breaks the idempotency, causing: #472

Changing a reference with another reference makes no sense to me, which is this feature kind of about. Its like fixing one leak by taking from another one thats not leaking ATM. We just flip for infinity as we can not truly determine which one is null, only by changing the arguments (a reference with another reference).

no PMD is making the assumption so this feature seems correct.

#473 (comment)