EqualsAvoidsNull not idempotent

[protocol7]

What version of OpenRewrite are you using?

• org.openrewrite:rewrite-core:8.47.2
• org.openrewrite.recipe:rewrite-static-analysis:2.3.0

What is the smallest, simplest way to reproduce the problem?

EqualsAvoidsNull will non-idempotently swap places of constants and string literals. We see this in our daily runs of the recipe in that the same code will switch back and forth every other day. The test case below is a minimised version of our real code.

I assume that the preferred order would be to have the string literal first.

  @Test
  void equalsAvoidsNullNonIdempotent() {
    rewriteRun(
        spec -> spec.recipe(new EqualsAvoidsNull()),
        // language=java
        java(
            """
            package com.helloworld;

            public class Foo {
                private static final String FOO = "";

                public void foo() {
                    FOO.equals("");
                    "".equals(FOO);
                }
            }
            """));
  }

org.opentest4j.AssertionFailedError: [Expected recipe to complete in 0 cycles, but took at least one more cycle. Between the last two executed cycles there were changes to "com/helloworld/Foo.java"]
expected:
  "package com.helloworld;

  public class Foo {
      private static final String FOO = "";

      public void foo() {
          FOO.equals("");
          "".equals(FOO);
      }
  }"
 but was:
  "package com.helloworld;

  public class Foo {
      private static final String FOO = "";

      public void foo() {
          "".equals(FOO);
          FOO.equals("");
      }
  }"

[Pankraz76]

thanks for the report. We will have a look into this.

[Pankraz76]

imho still open: #487

[Pankraz76]

@protocol7 have you retested the issue? I think its still open.

[protocol7]

Yes, now works as expected on latest OpenRewrite. This issue is closed, and I'm not sure I have enough context to know if #487 also required.

[Pankraz76]

Thanks — as long as you're happy, we are too.

Do you only having cases involving:

• Raw strings ("raw") — these should work
• as well as reference-to-reference cases? — These should flip infinitive, since the tests are failing for these cases.

[protocol7]

Currently we only have the raw strings case, but that might change as we're adding more code to be exposed to OpenRewrite.

[Pankraz76]

All right thanks - then we gonna meet up again, until fixed.

Cheers.