Improve "Add explicit Common Annotations dependencies" in "Migrate to Java 11"

[jevanlingen]

What's changed?

The counteract recipe now works as intended. When migrating to Java 17, it will update any added or updated dependency on jakarta.annotation:jakarta.annotation-api:1.3.5 to version 2.0.

What's your motivation?

The original PR

• feat: Missing "Add explicit Common Annotations dependencies" in "Migrate to Java 11" #456

introduced the AddCommonAnnotationsDependencies recipe. While useful, it made the migration chains harder to reason about. In rewrite-migrate-java, there are two major migration chains:

• Javax → Jakarta EE chain
• Java 7 → 8 → 11 → 17 → 21 → 25 chain

The AddCommonAnnotationsDependencies recipe started to conceptually mingle the two chains. As migrating to Java 11 requires some dependency to support the javax namespace, it needs to be there. However, if you want to migrate to newer versions than Java 11, the Java chain never actually updated the Javax namespace to the Jakarta namespace (the counteract recipe was originally part of the EE chain only).

In some cases, this could even lead to errors such as:

Execution failed for task ':compileJava'.  
> java.lang.NoSuchFieldError: Class com.sun.tools.javac.tree.JCTree$JCImport does not have member field 'com.sun.tools.javac.tree.JCTree qualid'

By adding the counteract recipe to the Java chain, we prevent these issues. It’s worth noting that the original counteract recipe wasn’t truly a “counter” recipe. It was more of a best-practice recipe; it's limited to the Jakarta EE chain and only worked for Spring Boot migrations.

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[jevanlingen]

ℹ️ The UpdateJakartaAnnotations2 recipe should not contain these ChangeType changes, as the JavaxAnnotationMigrationToJakartaAnnotation recipe, located in jakarta-ee-9.xml, does already do these migrations:

https://github.com/openrewrite/rewrite-migrate-java/blob/main/src/main/resources/META-INF/rewrite/jakarta-ee-9.yml#L94-L129

Because jakarta-ee-10 calls jakarta-ee-9, the namespace fix will already be applied.

---

The reason these ChangeType recipes were added here, was because there was a bug in the JavaxAnnotationMigrationToJakartaAnnotation recipe, what let to an unchanged javax namespace. That bug has been fixed, so we don't need there recipe here anymore.

[timtebeek]

Noting it here in case it pops up: there's small chance some of these recipes might have been customized, and those customizations would then refer to a recipe that no longer exists; that's benign when running a recipe, but could fail validation in tests. The solution then is to either update or remove those references in customized recipes.