Skip to content

Commit d9674d1

Browse files
committed
Delegate from RemoveIllegalSemicolons to RemoveExtraSemicolons
1 parent eec04ab commit d9674d1

File tree

3 files changed

+13
-90
lines changed

3 files changed

+13
-90
lines changed

src/main/java/org/openrewrite/java/migrate/RemoveIllegalSemicolons.java

Lines changed: 12 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,17 @@
1515
*/
1616
package org.openrewrite.java.migrate;
1717

18-
import org.openrewrite.ExecutionContext;
19-
import org.openrewrite.Preconditions;
2018
import org.openrewrite.Recipe;
21-
import org.openrewrite.TreeVisitor;
22-
import org.openrewrite.java.JavaIsoVisitor;
23-
import org.openrewrite.java.search.UsesJavaVersion;
24-
import org.openrewrite.java.tree.J;
19+
import org.openrewrite.staticanalysis.RemoveExtraSemicolons;
2520

21+
import java.util.List;
22+
23+
import static java.util.Collections.singletonList;
24+
25+
/**
26+
* @deprecated Use {@link RemoveExtraSemicolons} instead.
27+
*/
28+
@Deprecated
2629
public class RemoveIllegalSemicolons extends Recipe {
2730
@Override
2831
public String getDisplayName() {
@@ -33,22 +36,11 @@ public String getDisplayName() {
3336
public String getDescription() {
3437
//language=markdown
3538
return "Remove semicolons after package declarations and imports, no longer accepted in Java 21 as of " +
36-
"[JDK-8027682](https://bugs.openjdk.org/browse/JDK-8027682).";
39+
"[JDK-8027682](https://bugs.openjdk.org/browse/JDK-8027682).";
3740
}
3841

3942
@Override
40-
public TreeVisitor<?, ExecutionContext> getVisitor() {
41-
return Preconditions.check(new UsesJavaVersion<>(21), new JavaIsoVisitor<ExecutionContext>() {
42-
@Override
43-
public J.Import visitImport(J.Import _import, ExecutionContext ctx) {
44-
J.Import im = super.visitImport(_import, ctx);
45-
if (im.getPrefix().getWhitespace().contains(";")) {
46-
im = im.withPrefix(im.getPrefix()
47-
.withWhitespace(im.getPrefix().getWhitespace()
48-
.replaceAll("\\s*;(\\R*)\\s*", "$1")));
49-
}
50-
return im;
51-
}
52-
});
43+
public List<Recipe> getRecipeList() {
44+
return singletonList(new RemoveExtraSemicolons());
5345
}
5446
}

src/main/resources/META-INF/rewrite/java-version-21.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ tags:
2727
recipeList:
2828
- org.openrewrite.java.migrate.UpgradeToJava17
2929
- org.openrewrite.java.migrate.UpgradeBuildToJava21
30-
- org.openrewrite.java.migrate.RemoveIllegalSemicolons
30+
- org.openrewrite.staticanalysis.RemoveExtraSemicolons
3131
- org.openrewrite.java.migrate.lang.ThreadStopUnsupported
3232
- org.openrewrite.java.migrate.net.URLConstructorToURICreate
3333
# Fails to introduce new exception handling https://github.com/openrewrite/rewrite-migrate-java/issues/467

src/test/java/org/openrewrite/java/migrate/RemoveIllegalSemicolonsTest.java

Lines changed: 0 additions & 69 deletions
This file was deleted.

0 commit comments

Comments
 (0)