Skip to content

Update java-version-21.yml #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2025
Merged

Update java-version-21.yml #777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8186df7
Update java-version-21.yml
Jenson3210 Jun 24, 2025
2171522
Adjust test expectation for version postfix
Laurens-W Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/resources/META-INF/rewrite/java-version-21.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ recipeList:
- org.openrewrite.java.migrate.UpgradePluginsForJava21
- org.openrewrite.java.migrate.DeleteDeprecatedFinalize
- org.openrewrite.java.migrate.RemovedSubjectMethods
- org.openrewrite.java.migrate.SwitchPatternMatching
# - org.openrewrite.java.migrate.SwitchPatternMatching

---
type: specs.openrewrite.org/v1beta/recipe
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/openrewrite/java/migrate/jakarta/JavaxInjectToJakartaInjectTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ void projectWithJavaxInject() {
spec -> spec.after(actual -> assertThat(actual)
.contains("<groupId>jakarta.inject</groupId>")
.contains("<artifactId>jakarta.inject-api</artifactId>")
.containsPattern("<version>[0-9]+\\.[0-9]+\\.[0-9]+</version>")
.containsPattern("<version>[0-9]+\\.[0-9]+\\.[0-9]+[\\w\\W]*</version>")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a bit odd to me:

\w A word character: [a-zA-Z_0-9]
\W A non-word character: [^\w]

So then to me, [\\w\\W]* would seem equivalent to .*; correct?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct, I tried with .*? at first and that didn't match but I didn't realize it was due to the conservative matching

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 0840ea5

.actual())
)
);
Expand Down