Update java-version-21.yml #777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI is failing with and specifically on comparing versions: of Which I guess might have changed after openrewrite/rewrite#5662 EDIT: the same test fails in |
Laurens-W
approved these changes
Jun 24, 2025
github-project-automation
bot
moved this from In Progress
to Ready to Review
in OpenRewrite
Jenson3210
deleted the
disable-switch-pattern-matching-untill-issue-fixed
branch
timtebeek
reviewed
Jun 24, 2025
| .contains("<groupId>jakarta.inject</groupId>") | ||
| .contains("<artifactId>jakarta.inject-api</artifactId>") | ||
| .containsPattern("<version>[0-9]+\\.[0-9]+\\.[0-9]+</version>") | ||
| .containsPattern("<version>[0-9]+\\.[0-9]+\\.[0-9]+[\\w\\W]*</version>") |
There was a problem hiding this comment.
This looks a bit odd to me:
\w A word character: [a-zA-Z_0-9]
\W A non-word character: [^\w]
So then to me, [\\w\\W]* would seem equivalent to .*; correct?
There was a problem hiding this comment.
That's correct, I tried with .*? at first and that didn't match but I didn't realize it was due to the conservative matching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed we will not run this recipe untill the issue is identified