Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use non-adjusted p-values #50

Merged
merged 1 commit into from
May 25, 2024
Merged

use non-adjusted p-values #50

merged 1 commit into from
May 25, 2024

Conversation

szalata
Copy link
Collaborator

@szalata szalata commented May 24, 2024

Describe your changes

After recent evaluation of representations, we found out that non-adjusted p-values better preserve the magnitude of the change, especially for high p-values

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality (new method, new metric, ...)
    • Major changes
    • [ x] Minor changes
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

@szalata szalata requested a review from rcannood May 24, 2024 20:54
@rcannood rcannood merged commit 5934a85 into main May 25, 2024
6 checks passed
@rcannood rcannood deleted the change_to_nonadjusted branch May 25, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants