Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding AmbrosM's solution to methods #31

Merged
merged 37 commits into from
May 20, 2024
Merged

Conversation

andrew-benz
Copy link
Contributor

No description provided.

@andrew-benz andrew-benz requested a review from rcannood May 16, 2024 23:00
Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already a partial review; since I'm still working on other things I might already send you what I have so far :)

@andrew-benz
Copy link
Contributor Author

@rcannood Unfortunately the solution heavily depends on py_boost (https://github.com/sberbank-ai-lab/Py-Boost), which I was only able to run with CUDA 11 (not CUDA 12) and which requires a GPU. As far as I know there is no library with the exact same functionality but with CPU support that we could easily incorporate into this solution.

@andrew-benz
Copy link
Contributor Author

Looks like the test / viash test check failed due to the llvm-lite install:

#5 1.908   Downloading llvmlite-0.39.1.tar.gz (132 kB)
#5 1.946      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 132.8/132.8 kB 4.1 MB/s eta 0:00:00
#5 1.969   Preparing metadata (setup.py): started
#5 2.183   Preparing metadata (setup.py): finished with status 'error'
#5 2.186   error: subprocess-exited-with-error
#5 2.186   
#5 2.186   × python setup.py egg_info did not run successfully.
#5 2.186   │ exit code: 1
#5 2.186   ╰─> [8 lines of output]
#5 2.186       Traceback (most recent call last):
#5 2.186         File "<string>", line 2, in <module>
#5 2.186         File "<pip-setuptools-caller>", line 34, in <module>
#5 2.186         File "/tmp/pip-install-vx3d4fie/llvmlite_0097ae8b9f1e4097864f0886e2d76a65/setup.py", line 55, in <module>
#5 2.186           _guard_py_ver()
#5 2.186         File "/tmp/pip-install-vx3d4fie/llvmlite_0097ae8b9f1e4097864f0886e2d76a65/setup.py", line 52, in _guard_py_ver
#5 2.186           raise RuntimeError(msg.format(cur_py, min_py, max_py))
#5 2.186       RuntimeError: Cannot install on Python version 3.11.9; only versions >=3.7,<3.11 are supported.
#5 2.186       [end of output]
#5 2.186   
#5 2.186   note: This error originates from a subprocess, and is likely not a problem with pip.
#5 2.188 error: metadata-generation-failed

Is there any way to adjust the version of Python for just this component?

Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rcannood rcannood merged commit 061da00 into main May 20, 2024
6 checks passed
@rcannood rcannood deleted the ambros_m_judges_third_place branch May 20, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants