Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emd per matching sample metric #9

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

ghar1821
Copy link
Contributor

@ghar1821 ghar1821 commented Dec 18, 2024

Describe your changes

Added new metric emd_per_samples (PR #9):

  • metrics/emd_per_samples

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

@ghar1821 ghar1821 requested review from rcannood and removed request for rcannood December 18, 2024 11:06
@ghar1821 ghar1821 marked this pull request as draft December 18, 2024 11:20
@ghar1821 ghar1821 marked this pull request as ready for review December 18, 2024 11:29
@ghar1821 ghar1821 requested a review from rcannood December 18, 2024 11:30
Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! LGTM!

@rcannood rcannood merged commit 74f092a into main Dec 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants