Skip to content

Added a second circle for the upcoming groups... #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jyolewis wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added a second circle for the upcoming groups... #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .env
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
CLOUDINARY_CLOUD_NAME=demo
CLOUDINARY_CLOUD_NAME=fisherhall
Copy link
Copy Markdown
Member

@achan achan Sep 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to expose our actual Cloudinary account name, so we should revert this file 😊

11 changes: 10 additions & 1 deletion app/templates/index.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
</div>
</div>
<div class="row">
<div class="col-sm-offset-4 col-sm-4 group" {{action "viewEnglishService"}}>
<div class="col-sm-offset-2 col-sm-4 group" {{action "viewEnglishService"}}>
<img src={{cloudinary-fetch url="https://mcac.s3.amazonaws.com/groups/5c7d76a8-d195-4907-951d-5b3fb00c438d.jpg"
width=200
radius="max"
Expand All @@ -33,6 +33,15 @@
English Service
</div>
</div>
<div class="col-sm-4 group" {{action "viewEnglishService"}}>
Copy link
Copy Markdown
Member

@achan achan Sep 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clicking on this div would fire the viewEnglishService action, which we do not want. Since this is for "Coming soon," we probably don't want any actions at all.

<img src={{cloudinary-fetch url="https://mcac.s3.amazonaws.com/groups/5c7d76a8-d195-4907-951d-5b3fb00c438d.jpg"
width=200
radius="max"
height=200 crop="fill"}} />
<div class="description">
More Coming Soon... <i class="icon-cma logo"></i>
Copy link
Copy Markdown
Member

@achan achan Sep 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need the logo here. I meant that maybe the circle could be the logo... but even that probably doesn't look good. For now, just remove this logo.

</div>
</div>
</div>
</section>
{{outlet}}
Expand Down