Added a second circle for the upcoming groups...#158
Conversation
achan
left a comment
achan
left a comment
There was a problem hiding this comment.
Good start Joe. I added a couple suggestions as well as one last thing: In mobile view, we should add a top margin for all groups except for the first one. There's a specific way to do this in CSS. I'll let you look it up 😉
| @@ -1 +1 @@ | |||
| CLOUDINARY_CLOUD_NAME=demo | |||
| CLOUDINARY_CLOUD_NAME=fisherhall | |||
There was a problem hiding this comment.
We don't want to expose our actual Cloudinary account name, so we should revert this file 😊
| English Service | ||
| </div> | ||
| </div> | ||
| <div class="col-sm-4 group" {{action "viewEnglishService"}}> |
There was a problem hiding this comment.
Clicking on this div would fire the viewEnglishService action, which we do not want. Since this is for "Coming soon," we probably don't want any actions at all.
| radius="max" | ||
| height=200 crop="fill"}} /> | ||
| <div class="description"> | ||
| More Coming Soon... <i class="icon-cma logo"></i> |
There was a problem hiding this comment.
I don't think we need the logo here. I meant that maybe the circle could be the logo... but even that probably doesn't look good. For now, just remove this logo.
|
"In mobile view, we should add a top margin for all groups except for the first one." - is it the Nth-child attribut? If so, I've used it before. |
|
will make the upcoming changes tonight |
|
Try this style: http://www.w3schools.com/csSref/sel_first-of-type.asp |
2 participants
just need to find a suitable image