Allow decay only nuclides to be specified in Material for a depletion simulation
#2616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimwell
reviewed
Jul 20, 2023
yardasol
changed the title
materials.xml for a depletion simulation
yardasol
changed the title
materials.xml for a depletion simulationMaterial for a depletion simulation
Co-authored-by: Jonathan Shimwell <drshimwell@gmail.com>
paulromano
requested changes
Aug 31, 2023
There was a problem hiding this comment.
@yardasol Thanks so much for this improvement. You'll be happy to know that a request for this very feature came in today during the OpenMC monthly meeting! Sorry it took me a long time to look it over properly.
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
…s in coupled_operator.py
|
@paulromano I implemented you suggested change. Let me know what you think. |
|
Looks like the CI is failing. This is due to my new tests. I suspect this has to do with the most recent commit based on @paulromano's suggestion, as now the decay-only nuclides are passed to the C API which would cause the simulation to crash. |
yardasol
force-pushed
the
deplete-decay-only-nuclides
branch
from
60d7b61
to
6f0969d
Compare
|
@paulromano I was incorrect above, the issue was simpler than that. |
paulromano
approved these changes
Sep 13, 2023
stchaker
pushed a commit
to stchaker/openmc
that referenced
this pull request
Oct 25, 2023
…on simulation (openmc-dev#2616) Co-authored-by: Jonathan Shimwell <drshimwell@gmail.com> Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables users to specify decay-only nuclides in a
Materialwhen running transport-coupled depletion simulations. This could be useful for coupling with external interface codes, as well as for simulating scenarios where there may be buildup of these decay-only nuclides.Checklist
[ ] I have run clang-format on any C++ source files (if applicable)