Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing write flag to taf targets sign #329

Merged
merged 1 commit into from
Jul 26, 2023
Merged

fix: add missing write flag to taf targets sign #329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ and this project adheres to [Semantic Versioning][semver].
### Changed

### Fixed
- Add missing `write` flag to `taf targets sign` ([329])

[329]: https://github.com/openlawlibrary/taf/pull/329
## [0.26.0] - 07/12/2023

### Added
Expand Down
1 change: 1 addition & 0 deletions taf/api/targets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,7 @@ def register_target_files(
removed_targets_data,
keystore,
scheme=scheme,
write=write,
)

if write:
Expand Down
2 changes: 1 addition & 1 deletion taf/tools/targets/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ def sign(path, keystore, keys_description, scheme):
try:
register_target_files(path, keystore=keystore,
roles_key_infos=keys_description,
scheme=scheme)
scheme=scheme, write=True)
except TAFError as e:
click.echo()
click.echo(str(e))
Expand Down