Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing write flag to taf targets sign #329

Merged
merged 1 commit into from
Jul 26, 2023
Merged

fix: add missing write flag to taf targets sign #329

merged 1 commit into from
Jul 26, 2023

Conversation

n-dusan
Copy link
Contributor

@n-dusan n-dusan commented Jul 26, 2023

Description (e.g. "Related to ...", etc.)

Signing was not working without adding this flag

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Changelog has been updated, as needed (see CHANGELOG.md)

@n-dusan
fix: add missing write flag to taf targets sign
745cf25 
Signing was not working without adding this flag
@n-dusan n-dusan force-pushed the ndusan/fix-targets-signing branch from 1718fcf to 745cf25 Compare July 26, 2023 15:53
@n-dusan n-dusan changed the title fix: add missing write flag to taf targets sign fix: add missing write flag to taf targets sign Jul 26, 2023
@n-dusan n-dusan changed the title fix: add missing write flag to taf targets sign fix: add missing write flag to taf targets sign Jul 26, 2023
@n-dusan n-dusan self-assigned this Jul 26, 2023
@n-dusan n-dusan added the bug Something isn't working label Jul 26, 2023
@n-dusan n-dusan requested a review from renatav July 26, 2023 15:53
@n-dusan n-dusan merged commit a74e9af into master Jul 26, 2023
25 checks passed
@n-dusan n-dusan deleted the ndusan/fix-targets-signing branch July 26, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatav renatav renatav approved these changes

Assignees

@n-dusan n-dusan

Labels
bug Something isn't working security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@n-dusan @renatav