Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add workspace diagnostic support #363

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

karthiknadig
Copy link
Contributor

Description (e.g. "Related to ...", etc.)

Adds workspace diagnostic request support.

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly

@karthiknadig karthiknadig force-pushed the diagnostic1 branch 2 times, most recently from 2439049 to 4e824e5 Compare September 1, 2023 18:25
@karthiknadig karthiknadig marked this pull request as ready for review September 1, 2023 18:42
@tombh tombh self-requested a review September 1, 2023 19:26
@tombh
Copy link
Collaborator

tombh commented Sep 1, 2023

Does this contribute to LSP 3.17 support? We've got a tracking issue at #346

@karthiknadig
Copy link
Contributor Author

@tombh Yes. The diagnostics had two parts document diagnostics and workspace diagnostics. My Previous PR (#360) added document diagnostic. This one adds the workspace diagnostic.

@tombh tombh merged commit 94fdef3 into openlawlibrary:main Sep 1, 2023
@tombh
Copy link
Collaborator

tombh commented Sep 1, 2023

Thank you ✨

@karthiknadig karthiknadig deleted the diagnostic1 branch September 1, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants