Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add document diagnostic capability #360

Merged
merged 1 commit into from
Aug 31, 2023
Merged

feat: Add document diagnostic capability #360

merged 1 commit into from
Aug 31, 2023

Conversation

karthiknadig
Copy link
Contributor

@karthiknadig karthiknadig commented Aug 30, 2023 •
edited
Loading

Description (e.g. "Related to ...", etc.)

Implements diagnostic pull feature mentioned in #346

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly

@karthiknadig karthiknadig changed the title Add document diagnostic capability feature: Add document diagnostic capability Aug 30, 2023
@karthiknadig karthiknadig reopened this Aug 30, 2023
@karthiknadig karthiknadig changed the title feature: Add document diagnostic capability feat: Add document diagnostic capability Aug 30, 2023
@karthiknadig karthiknadig reopened this Aug 30, 2023
@karthiknadig karthiknadig force-pushed the diagnostic1 branch 3 times, most recently from fdb8938 to 8030020 Compare August 30, 2023 23:06
@karthiknadig karthiknadig marked this pull request as ready for review August 30, 2023 23:27
alcarney
alcarney approved these changes Aug 31, 2023
View reviewed changes
Copy link
Collaborator

@alcarney alcarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@tombh tombh merged commit eeca839 into openlawlibrary:main Aug 31, 2023
@tombh
Copy link
Collaborator

tombh commented Aug 31, 2023

Thank you ✨

@tombh tombh mentioned this pull request Aug 31, 2023
Merged
6 tasks
@karthiknadig karthiknadig deleted the diagnostic1 branch August 31, 2023 17:30
@alcarney alcarney mentioned this pull request Jun 26, 2023
Closed
7 tasks
This was referenced Sep 1, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcarney alcarney alcarney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karthiknadig @tombh @alcarney