-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: lpcde: Estimation and Inference for Local Polynomial Conditional Density Estimators #7241
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Software report:
Commit count by author:
|
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: 🔴 Failed to discover a valid open source license |
Review checklist for @salbalkusConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi @rajitachandak, I have a few substantive comments on the software that I'd like to post as issues in the GitHub repo, as recommended by JOSS. Would you mind enabling the "Issues" tab on your package's repo so that I can do so? Thanks! |
Hello @salbalkus, I have enabled Issues/Discussions for the repo, you should now be able to add your comments there. Thanks! |
Hi @rajitachandak my first pass is now complete; overall, the paper and the software look great. The remaining unchecked items pertain to some issues that I've filed above; @spholmes I assume I should wait to check these until the issues have been addressed? Thanks! |
Submitting author: @rajitachandak (Rajita Chandak)
Repository: https://github.com/nppackages/lpcde
Branch with paper.md (empty if default branch):
Version: v.0.1.4
Editor: @spholmes
Reviewers: @salbalkus
Archive: Pending
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@salbalkus, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @spholmes know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @salbalkus
The text was updated successfully, but these errors were encountered: