Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS review: Automatic bandwidth selection error #10

Open
salbalkus opened this issue Oct 4, 2024 · 1 comment
Open

JOSS review: Automatic bandwidth selection error #10

salbalkus opened this issue Oct 4, 2024 · 1 comment

Comments

@salbalkus
Copy link

Raising as part of JOSS review openjournals/joss-reviews#7241

Having an automatic bandwidth selection for conditional density estimation is a very useful feature -- kudos for implementing this. I may be incorrect about this, but the documentation for lpcde seems to imply that when the bw is not specified, the bandwidth is chosen according to the optimization strategy implemented in lpbwcde. However, when I run the following code:

n=100
x_data = matrix(rbeta(n, 2, 4))
y_data = matrix(rgamma(n, 10, 1/x_data))
y_grid = seq(from=1, to=5, length.out=10)

model1 = lpcde::lpcde(x_data=x_data, y_data=y_data, y_grid=y_grid, x= 0.5)

it returns Error in matrix(0L, ncol = eff_n) : data is too long. Is this correct? I'm not sure what the true problem is based on the error message.

@salbalkus salbalkus changed the title JOSS review: automatic bandwidth selection error JOSS review: Automatic bandwidth selection error Oct 4, 2024
@salbalkus
Copy link
Author

On a somewhat related note, there's a slight typo in the lpbwcde documentation: "conditionaldensity" should be "conditional density"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant