-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: tidylda: An R Package for Latent Dirichlet Allocation Using ''tidyverse'' Conventions #6800
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: 🟡 License found: |
|
@TommyJones, @maximelenormand, @hassaniazi, This is the review thread for the paper. All of our communications will happen here from now on. Please read the "Reviewer instructions & questions" in the first comment above. For @maximelenormand, @hassaniazi - Both reviewers have checklists at the top of this thread (in that first comment) with the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. There are also links to the JOSS reviewer guidelines. As you are probably already aware, The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention #6800 so that a link is created to this thread (and I can keep an eye on what is happening). Please also feel free to comment and ask questions on this thread. In my experience, it is better to post comments/questions/suggestions as you come across them instead of waiting until you've reviewed the entire package. We aim for the review process to be completed within about 4-6 weeks but please make a start well ahead of this as JOSS reviews are by their nature iterative and any early feedback you may be able to provide to the author will be very helpful in meeting this schedule. Thanks in advance and let me know if you have any questions!! |
Review checklist for @maximelenormandConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi @maximelenormand, @hassaniazi- Just wanted to check in briefly. How's the review going thus far? Do let me know if you need anything from my side with respect to the same. Thanks for reviewing this manuscript again! |
Hi @kanishkan91, everything is going well. I have opened two issues regarding the general checks and documentation. One of them is already closed. I will go more in-depth into the review of functionalities, documentation, and the paper by the end of the month. |
Review checklist for @hassaniaziConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi @kanishkan91, I've finished my review.
|
@hassaniazi and @maximelenormand Thanks so much for review comments thus far! |
Hi @kanishkan91, I have finished my review. My concerns have been addressed. |
@editorialbot generate pdf |
I've made several updates to the paper based on reviewer comments. Thanks @maximelenormand and @hassaniazi for your comments so far! |
@hassaniazi - Would you mind taking a look over the next few days to see if your issues are also addressed? Thanks in advance! |
Ok. Those duplicate entries are removed. |
@editorialbot recommend-accept |
|
|
👋 @openjournals/dsais-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5672, then you can now move forward with accepting the submission by compiling again with the command |
@TommyJones I have recommended this for acceptance again now. I will be reading through the paper for typos etc. shortly. The AEiC in this submission track will review shortly and if all goes well this will go live soon! Once again, Big thank you to @hassaniazi and @maximelenormand for reviewing! JOSS is volunteer run and relies heavily on researchers such as yourself. |
Amazing. Thank you @kanishkan91 for running this process. And big thanks to @hassaniazi and @maximelenormand for your time, effort, and for the helpful comments making the paper and package better. 🎉 |
🔍 checking out the following:
|
@editorialbot generate pdf |
👋 @TommyJones - I just need you to address the following before I can move to accept:
In the paper:
I will then move forward with accepting this paper for publication. |
@crvernon, I've addressed these issues as described below. (Excuse the list. GitHub isn't letting me check boxes in others' comments.)
I've pushed the latest version to the repo. Should be good to check again. Thank you! |
@editorialbot set v0.06.999 as version |
Done! version is now v0.06.999 |
@editorialbot generate pdf |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
🥳 Congratulations on your new publication @TommyJones! Many thanks to @kanishkan91 for editing and @maximelenormand and @hassaniazi for your time, hard work, and expertise!! JOSS wouldn't be able to function nor succeed without your efforts. Please consider becoming a reviewer for JOSS if you are not already: https://reviewers.joss.theoj.org/join |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
You all are amazing! Thank you!
Sent with Shortwave <https://www.shortwave.com?utm_medium=email&utm_content=signature&utm_source=am9uZXMudGhvcy53QGdtYWlsLmNvbQ==>
On Thu Jul 25, 2024, 04:06 PM GMT, The Open Journals editorial robot ***@***.***> wrote:
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉
If you would like to include a link to your paper from your README use the following code snippets:
Markdown: [![DOI](https://joss.theoj.org/papers/10.21105/joss.06800/status.svg)](https://doi.org/10.21105/joss.06800) HTML: <a style="border-width:0" href="https://doi.org/10.21105/joss.06800"> <img src="https://joss.theoj.org/papers/10.21105/joss.06800/status.svg" alt="DOI badge" > </a> reStructuredText: .. image:: https://joss.theoj.org/papers/10.21105/joss.06800/status.svg :target: https://doi.org/10.21105/joss.06800
This is how it will look in your documentation:
[image] <https://doi.org/10.21105/joss.06800>
… We need your help!
The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
- Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join <https://reviewers.joss.theoj.org/join>
- Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss <https://numfocus.org/donate-to-joss>
—
Reply to this email directly, view it on GitHub <#6800 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGCQARAFWNSGRT7DTJC6ADZOEO77AVCNFSM6AAAAABINQNS2SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJQHAZDCNRZGE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@editorialbot generate my checklist |
@sash19 I can't do that because you are not a reviewer |
Submitting author: @TommyJones (Tommy Jones)
Repository: https://github.com/TommyJones/tidylda
Branch with paper.md (empty if default branch): main
Version: v0.06.999
Editor: @kanishkan91
Reviewers: @maximelenormand, @hassaniazi
Archive: 10.5281/zenodo.12809519
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@maximelenormand & @hassaniazi, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @kanishkan91 know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @maximelenormand
📝 Checklist for @hassaniazi
The text was updated successfully, but these errors were encountered: