Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: tidylda: An R Package for Latent Dirichlet Allocation Using ''tidyverse'' Conventions #6760

Closed
editorialbot opened this issue May 17, 2024 · 44 comments
Assignees
Labels
C++ pre-review R TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented May 17, 2024

Submitting author: @TommyJones (Tommy Jones)
Repository: https://github.com/TommyJones/tidylda
Branch with paper.md (empty if default branch): main
Version: v0.0.5
Editor: @kanishkan91
Reviewers: @maximelenormand, @hassaniazi
Managing EiC: Chris Vernon

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/04f617f818a4ef71ea7ffa232016216c"><img src="https://joss.theoj.org/papers/04f617f818a4ef71ea7ffa232016216c/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/04f617f818a4ef71ea7ffa232016216c/status.svg)](https://joss.theoj.org/papers/04f617f818a4ef71ea7ffa232016216c)

Author instructions

Thanks for submitting your paper to JOSS @TommyJones. Currently, there isn't a JOSS editor assigned to your paper.

@TommyJones if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning labels May 17, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

@crvernon
Copy link

👋 @TommyJones - Thank you for your submission to JOSS! Could you please include your paper and supporting files in a branch of the submission repository (https://github.com/TommyJones/tidylda) instead of in a separate repo? Thanks.

@TommyJones
Copy link

@crvernon - Done! Do you need me to resubmit through the JOSS portal?

@crvernon
Copy link

Thanks and all is well! I can do things from here.

@TommyJones
Copy link

TommyJones commented May 17, 2024 via email

@openjournals openjournals deleted a comment from editorialbot May 17, 2024
@crvernon
Copy link

@editorialbot set main as branch

@editorialbot
Copy link
Collaborator Author

Done! branch is now main

@crvernon
Copy link

@editorialbot check repository

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.03 s (1690.1 files/s, 276996.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
R                               25            988           1408           2647
C++                              4            319            354            664
Markdown                         8            126              0            540
C/C++ Header                     7            186            130            442
Rmd                              5            284            336            404
TeX                              1              4              0            162
YAML                             4             33             12            120
SVG                              1              0              0             18
C                                1              0              0              1
-------------------------------------------------------------------------------
SUM:                            56           1940           2240           4998
-------------------------------------------------------------------------------

Commit count by author:

   435	Tommy Jones
     9	Tommy
     3	Brendan Knapp

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1518

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: Other (Check here for OSI approval)

@crvernon
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Checking the BibTeX entries failed with the following error:

Failed to parse BibTeX on value "-01-01" (NAME) [#<BibTeX::Bibliography data=[19]>, "@", #<BibTeX::Entry >, {:author=>["Max Khun and Hadley Wickham"], :title=>["Tidymodels"], :year=>"2018", :urldate=>"2021"}]

@crvernon
Copy link

@editorialbot invite @kanishkan91 as editor

👋 @kanishkan91 are you able to take this one on?

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@crvernon
Copy link

@TommyJones I think you may need to add brackets around your dates on this ref to get it to compile:

@online{tidymodels,
  author = {Max Khun and Hadley Wickham},
  title = {Tidymodels},
  year = 2018,
  urldate = 2021-01-01,
  url = {https://www.tidymodels.org/}
}

Per the error...

Checking the BibTeX entries failed with the following error:

Failed to parse BibTeX on value "-01-01" (NAME) [#<BibTeX::Bibliography data=[19]>, "@", #<BibTeX::Entry >, {:author=>["Max Khun and Hadley Wickham"], :title=>["Tidymodels"], :year=>"2018", :urldate=>"2021"}]

@TommyJones
Copy link

I just pushed a change with brackets around the date.

@editorialbot check references

@crvernon
Copy link

@editorialbot check references

@crvernon
Copy link

@TommyJones - FYI, you have to place the editorialbot commands at the top of the comment. Thanks!

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.21105/joss.01686 is OK
- 10.18637/jss.v091.i02 is OK
- 10.21105/joss.00774 is OK
- 10.21105/joss.00037 is OK

MISSING DOIs

- No DOI given, and none found for title: text2vec
- No DOI given, and none found for title: textmineR: Functions for Text Mining and Topic Mod...
- No DOI given, and none found for title: lda
- No DOI given, and none found for title: broom: An R Package for Converting Statistical Ana...
- No DOI given, and none found for title: R: A Language and Environment for Statistical Comp...
- No DOI given, and none found for title: topicmodels:  An R Package for Fitting Topic Model...
- No DOI given, and none found for title: Software Framework for Topic Modelling with Large ...
- No DOI given, and none found for title: Text Mining Infrastructure in R
- No DOI given, and none found for title: MALLET: A Machine Learning for Language Toolkit
- 10.1002/wics.1212 may be a valid DOI for title: The Comprehensive R Archive Network
- No DOI given, and none found for title: Latent Dirichlet Allocation
- No DOI given, and none found for title: Latent Dirichlet Allocation for Natural Language S...
- No DOI given, and none found for title: Conventions for R Modeling Packages
- No DOI given, and none found for title: Tidy data
- No DOI given, and none found for title: Tidymodels

INVALID DOIs

- doi:10.18637/jss.v083.b01 is INVALID (failed connection)

@crvernon
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@TommyJones
Copy link

TommyJones commented May 18, 2024

Do you still need me to suggest reviewers? Both Emil Hvitfeldt (EmilHvitfeldt) and Julia Silge (juliasilge) would be excellent.

Of the people who have pre-voluneered to review papers, both Harish Varma Siravuri and bagheria are tagged with all three of R, C++, and natural language processing.

@crvernon
Copy link

I am the Associate Editor in Chief of this submission track but have invited a topic editor to edit your submission. Once they accept, they can get some reviewers assigned for you and get you in review. Thanks for the suggestions as that will help them get things moving more quickly.

@kanishkan91
Copy link

@crvernon I can edit this submission

@kanishkan91
Copy link

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @kanishkan91 is now the editor

@kanishkan91
Copy link

kanishkan91 commented May 24, 2024

@harishsiravuri Would you be interested in reviewing this software paper for the Journal of Open Source Software?

@kanishkan91
Copy link

@bagheria Would you be interested in reviewing this paper for JOSS?

@kanishkan91
Copy link

@maximelenormand Given your publication history in JOSS, would you be interested in reviewing this software paper for JOSS?

@maximelenormand
Copy link

Hi @kanishkan91, I am available to review this paper for JOSS.

@kanishkan91
Copy link

@editorialbot add @maximelenormand as reviewer

@editorialbot
Copy link
Collaborator Author

@maximelenormand added to the reviewers list!

@kanishkan91
Copy link

@jonschwenk, @jsta given your previous publication with JOSS, would either of you be interested in reviewing this software package and paper for JOSS?

@kanishkan91
Copy link

@brunomontezano Given your reviewing experience with JOSS, would you be interested in reviewing this software package and paper for JOSS?

@brunomontezano
Copy link

Hello @kanishkan91! Unfortunately in the next couple weeks I'll be very busy. But after that, I'll probably be available for reviewing if still needed, it looks like an interesting piece of work. Thank you a lot for the invite!

@kanishkan91
Copy link

@brunomontezano Thanks! If I still need a reviewer 2 weeks from now, will reach out.

@kanishkan91
Copy link

@hassaniazi Would you be interested in this review?

@kanishkan91
Copy link

@editorialbot add @hassaniazi as reviewer

@editorialbot
Copy link
Collaborator Author

@hassaniazi added to the reviewers list!

@kanishkan91
Copy link

@TommyJones , @hassaniazi and @maximelenormand - Looks like we can get this review started. I'l start it over in another issue and post detailed instructions for reviewers.

@kanishkan91
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #6800.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ pre-review R TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning
Projects
None yet
Development

No branches or pull requests

6 participants