-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: PyBADS: Fast and robust black-box optimization in Python #5694
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
Reviewers @max-little and @gaxler, please let me know if you have any questions about how to get started on your reviews! @GurjeetSinghSangra, at some point be sure to address those missing DOI's that got flagged above. |
@editorialbot generate pdf |
@editorialbot generate pdf |
@editorialbot check references |
|
👋 Hi reviewers @max-little and @gaxler, just checking in again on this! |
👋 Hi again @max-little and @gaxler, any updates on when you'll be able to start your reviews? |
@max-little and @gaxler, are you still able to review this submission to JOSS? |
Review checklist for @gaxlerConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Thanks for getting things started here, @gaxler! Checking in with @max-little again... 🔔 |
Sent an email to @max-little to check in; if I don't get a response in a few days I'll find a replacement reviewer. (link to pre-review for my own reference here so I don't re-ask the same people who already said no: #5544 ) |
👋 @jungtaekkim, would you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html |
Hi @rkurchin, I am willing to review this submission. Please add me as a reviewer. |
@editorialbot add @jungtaekkim as reviewer |
@jungtaekkim added to the reviewers list! |
I apologise for the missing DOIS, there was a bad copy-paste of the bibliography in the last commit. |
@editorialbot recommend-accept |
|
|
👋 @openjournals/dsais-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5053, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot generate pdf |
@editorialbot check references |
|
Dear @rkurchin, after a final review of the paper, we noticed that the acknowledgement of the paper was missing some grant information about the CSC computation resource. Consequently, we just did a small edit in the acknowledgement section and I pushed the changes in the repository branch.
Could you please rerun the acceptance command? |
@editorialbot recommend-accept (not sure if it's actually necessary for me to do it again, but will just in case) |
|
|
👋 @openjournals/dsais-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5056, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
I'm sorry @GurjeetSinghSangra, I'm afraid I can't do that. That's something only eics are allowed to do. |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@jungtaekkim, @vankesteren – many thanks for your reviews here and to @rkurchin for editing this submission! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨ @GurjeetSinghSangra – your paper is now accepted and published in JOSS ⚡🚀💥 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Congratulations to all authors @GurjeetSinghSangra! Also, thank you @rkurchin, @vankesteren, and @arfon. |
We want to thank all the reviewers, editors and the people involved in this review procedure! Finally, we officially published this work in JOSS, expanding the reach of PyBADS to a broader audience of researchers. |
Submitting author: @GurjeetSinghSangra (Gurjeet Singh)
Repository: https://github.com/acerbilab/pybads
Branch with paper.md (empty if default branch): joss-submission
Version: 1.0.4
Editor: @rkurchin
Reviewers: @jungtaekkim, @vankesteren
Archive: 10.5281/zenodo.10696782
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@max-little & @gaxler, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @rkurchin know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @jungtaekkim
📝 Checklist for @vankesteren
The text was updated successfully, but these errors were encountered: