Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: madupite: A High-Performance Distributed Solver for Large-Scale Markov Decision Processes #7247

Open
editorialbot opened this issue Sep 20, 2024 · 38 comments
Assignees
Labels
C++ pre-review Python TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Sep 20, 2024

Submitting author: @gmatilde (Matilde Gargiani)
Repository: https://github.com/madupite/madupite
Branch with paper.md (empty if default branch):
Version: v1.0.0
Editor: @logological
Reviewers: Pending
Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/b7796be0782d9feb0bf5fb3bc37bc7e4"><img src="https://joss.theoj.org/papers/b7796be0782d9feb0bf5fb3bc37bc7e4/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/b7796be0782d9feb0bf5fb3bc37bc7e4/status.svg)](https://joss.theoj.org/papers/b7796be0782d9feb0bf5fb3bc37bc7e4)

Author instructions

Thanks for submitting your paper to JOSS @gmatilde. Currently, there isn't a JOSS editor assigned to your paper.

@gmatilde if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Sep 20, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.5281/zenodo.11844058 is OK
- 10.1111/ecog.00888 is OK
- 10.1287/inte.15.6.73 is OK
- 10.1016/j.ifacol.2016.07.012 is OK
- 10.2172/2205494 is OK
- 10.1016/j.parco.2021.102831 is OK
- 10.1007/s10107-014-0783-z is OK
- 10.1109/LCSYS.2022.3181213 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Inexact Policy Iteration Methods for Large-Scale M...
- No DOI given, and none found for title: Markov decision processes with applications to fin...
- No DOI given, and none found for title: Handbook of Markov Decision Processes: Methods and...
- No DOI given, and none found for title: PETSc Web page
- No DOI given, and none found for title: nanobind: tiny and efficient C++/Python bindings
- No DOI given, and none found for title: Dynamic Programming and Optimal Control, Vol. II
- No DOI given, and none found for title: Dynamic Programming
- No DOI given, and none found for title: Reinforcement Learning: An Introduction

❌ MISSING DOIs

- 10.1016/j.ifacol.2023.10.316 may be a valid DOI for title: Inexact GMRES Policy Iteration for Large-Scale Mar...
- 10.1109/tac.2023.3270060 may be a valid DOI for title: Parallel and Flexible Dynamic Programming via the ...
- 10.1007/978-3-319-47766-4_6 may be a valid DOI for title: Markov Decision Processes for Screening and Treatm...
- 10.1007/978-1-4612-1986-6_8 may be a valid DOI for title: Efficient Management of Parallelism in Object Orie...

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.05 s (1137.0 files/s, 301559.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
SVG                              2              0             39           9447
C++                             11            300            113           1417
Python                          14            300            125            898
C/C++ Header                     8            157            123            554
Jupyter Notebook                 3              0            657            379
reStructuredText                 8            305            397            216
TeX                              1              0              0            180
CMake                            1             26             18            122
YAML                             4             10             13            122
Markdown                         3             40              0            116
DOS Batch                        1              8              1             26
TOML                             1              3              0             23
make                             1              4              7              9
Bourne Shell                     3              6             11              7
-------------------------------------------------------------------------------
SUM:                            61           1159           1504          13516
-------------------------------------------------------------------------------

Commit count by author:

   148	Robin Sieber
   125	Robin
    79	Philip Pawlowsky
    64	Vaclav Hapla
    44	gmatilde
     6	vhapla
     5	ppawlowsky
     4	philippawlowsky
     2	Matilde Gargiani

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1253

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

PyBADS: Fast and robust black-box optimization in Python
Submitting author: @GurjeetSinghSangra
Handling editor: @rkurchin (Active)
Reviewers: @jungtaekkim, @vankesteren
Similarity score: 0.7104

pyOptSparse: A Python framework for large-scale constrained nonlinear optimization of sparse systems
Submitting author: @nwu63
Handling editor: @poulson (Retired)
Reviewers: @jgoldfar, @vissarion, @matbesancon
Similarity score: 0.7063

Pakman: a modular, efficient and portable tool for approximate Bayesian inference
Submitting author: @ThomasPak
Handling editor: @jedbrown (Active)
Reviewers: @jmlarson1, @gonsie
Similarity score: 0.7061

PySD: System Dynamics Modeling in Python
Submitting author: @rogersamso
Handling editor: @pdebuyl (Active)
Reviewers: @blsqr, @sixpearls
Similarity score: 0.6982

pymdp: A Python library for active inference in discrete state spaces
Submitting author: @conorheins
Handling editor: @emdupre (Active)
Reviewers: @seankmartin, @patrickmineault
Similarity score: 0.6966

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@danielskatz
Copy link

👋 @gmatilde - thanks for your submission.

While I look for an editor, you could work on the possibly missing DOIs that editorialbot suggests, but note that some may be incorrect. Please feel free to make changes to your .bib file, then use the command @editorialbot check references to check again, and the command @editorialbot generate pdf when the references are right to make a new PDF. editorialbot commands need to be the first entry in a new comment.

@danielskatz
Copy link

👋 @faroit - would you be able to edit this JOSS submission?

@danielskatz
Copy link

@editorialbot invite @faroit as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@faroit
Copy link

faroit commented Sep 20, 2024

@danielskatz sorry this is outside of my domain but can probably contribute reviewers once an editor is found

@danielskatz
Copy link

👋 @logological - Do you think that you could edit this JOSS submission?

@danielskatz
Copy link

@editorialbot invite @logological as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@gmatilde
Copy link

👋 @gmatilde - thanks for your submission.

While I look for an editor, you could work on the possibly missing DOIs that editorialbot suggests, but note that some may be incorrect. Please feel free to make changes to your .bib file, then use the command @editorialbot check references to check again, and the command @editorialbot generate pdf when the references are right to make a new PDF. editorialbot commands need to be the first entry in a new comment.

Dear Daniel, thanks a lot for your message. We have just added the missing DOIs.

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.5281/zenodo.11844058 is OK
- 10.1111/ecog.00888 is OK
- 10.1287/inte.15.6.73 is OK
- 10.1007/978-3-319-47766-4_6 is OK
- 10.1016/j.ifacol.2016.07.012 is OK
- 10.2172/2205494 is OK
- 10.1007/978-1-4612-1986-6_8 is OK
- 10.1016/j.parco.2021.102831 is OK
- 10.1007/s10107-014-0783-z is OK
- 10.1109/LCSYS.2022.3181213 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Inexact Policy Iteration Methods for Large-Scale M...
- No DOI given, and none found for title: Markov decision processes with applications to fin...
- No DOI given, and none found for title: Handbook of Markov Decision Processes: Methods and...
- No DOI given, and none found for title: PETSc Web page
- No DOI given, and none found for title: nanobind: tiny and efficient C++/Python bindings
- No DOI given, and none found for title: Dynamic Programming and Optimal Control, Vol. II
- No DOI given, and none found for title: Dynamic Programming
- No DOI given, and none found for title: Reinforcement Learning: An Introduction

❌ MISSING DOIs

- 10.1109/tac.2023.3270060 may be a valid DOI for title: Parallel and Flexible Dynamic Programming via the ...

❌ INVALID DOIs

- https://doi.org/10.1016/j.ifacol.2023.10.316 is INVALID because of 'https://doi.org/' prefix

@danielskatz
Copy link

@gmatilde - thanks, though it looks like a couple more changes are still needed... (maybe you're working on them now)

@gmatilde
Copy link

yes :) I just pushed again

@gmatilde
Copy link

this is a list of reviewers who we think might be interested in reviewing our paper:

  • Martin Huber @mhubii
  • Dominic Kempf @dokempf
  • @himscipy
  • @sixpearls

@gmatilde
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1016/j.ifacol.2023.10.316 is OK
- 10.5281/zenodo.11844058 is OK
- 10.1111/ecog.00888 is OK
- 10.1287/inte.15.6.73 is OK
- 10.1007/978-3-319-47766-4_6 is OK
- 10.1016/j.ifacol.2016.07.012 is OK
- 10.2172/2205494 is OK
- 10.1007/978-1-4612-1986-6_8 is OK
- 10.1016/j.parco.2021.102831 is OK
- 10.1007/s10107-014-0783-z is OK
- 10.1109/LCSYS.2022.3181213 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Inexact Policy Iteration Methods for Large-Scale M...
- No DOI given, and none found for title: Markov decision processes with applications to fin...
- No DOI given, and none found for title: Handbook of Markov Decision Processes: Methods and...
- No DOI given, and none found for title: PETSc Web page
- No DOI given, and none found for title: nanobind: tiny and efficient C++/Python bindings
- No DOI given, and none found for title: Dynamic Programming and Optimal Control, Vol. II
- No DOI given, and none found for title: Dynamic Programming
- No DOI given, and none found for title: Reinforcement Learning: An Introduction

❌ MISSING DOIs

- 10.1109/tac.2023.3270060 may be a valid DOI for title: Parallel and Flexible Dynamic Programming via the ...

❌ INVALID DOIs

- None

@gmatilde
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1016/j.ifacol.2023.10.316 is OK
- 10.1109/TAC.2023.3270060 is OK
- 10.5281/zenodo.11844058 is OK
- 10.1111/ecog.00888 is OK
- 10.1287/inte.15.6.73 is OK
- 10.1007/978-3-319-47766-4_6 is OK
- 10.1016/j.ifacol.2016.07.012 is OK
- 10.2172/2205494 is OK
- 10.1007/978-1-4612-1986-6_8 is OK
- 10.1016/j.parco.2021.102831 is OK
- 10.1007/s10107-014-0783-z is OK
- 10.1109/LCSYS.2022.3181213 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Inexact Policy Iteration Methods for Large-Scale M...
- No DOI given, and none found for title: Markov decision processes with applications to fin...
- No DOI given, and none found for title: Handbook of Markov Decision Processes: Methods and...
- No DOI given, and none found for title: PETSc Web page
- No DOI given, and none found for title: nanobind: tiny and efficient C++/Python bindings
- No DOI given, and none found for title: Dynamic Programming and Optimal Control, Vol. II
- No DOI given, and none found for title: Dynamic Programming
- No DOI given, and none found for title: Reinforcement Learning: An Introduction

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@gmatilde
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

PyBADS: Fast and robust black-box optimization in Python
Submitting author: @GurjeetSinghSangra
Handling editor: @rkurchin (Active)
Reviewers: @jungtaekkim, @vankesteren
Similarity score: 0.7104

pyOptSparse: A Python framework for large-scale constrained nonlinear optimization of sparse systems
Submitting author: @nwu63
Handling editor: @poulson (Retired)
Reviewers: @jgoldfar, @vissarion, @matbesancon
Similarity score: 0.7064

Pakman: a modular, efficient and portable tool for approximate Bayesian inference
Submitting author: @ThomasPak
Handling editor: @jedbrown (Active)
Reviewers: @jmlarson1, @gonsie
Similarity score: 0.7060

PySD: System Dynamics Modeling in Python
Submitting author: @rogersamso
Handling editor: @pdebuyl (Active)
Reviewers: @blsqr, @sixpearls
Similarity score: 0.6985

pymdp: A Python library for active inference in discrete state spaces
Submitting author: @conorheins
Handling editor: @emdupre (Active)
Reviewers: @seankmartin, @patrickmineault
Similarity score: 0.6963

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@logological
Copy link

👋 @logological - Do you think that you could edit this JOSS submission?

It's a bit outside my area but I could take it on if there's no one more suitable available. I'm at a conference this week but could start the editing process next week.

@danielskatz
Copy link

Thanks @logological - Given loads on existing reviewers, I'm happy that you are willing to do this. I'll assign it to you now, but no there's no need to start it until next week...

@danielskatz
Copy link

@editorialbot assign @logological as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @logological is now the editor

@logological
Copy link

@gmatilde I'm now ready to start the editing process – thanks for bearing with me. I see no obvious problems with your suggested reviewers so I'll go ahead and start inviting them.

@logological
Copy link

@mhubii @dokempf @Himscipy We've received a submission entitled "madupite: A High-Performance Distributed Solver for Large-Scale Markov Decision Processes". Would you be interested in reviewing it for the Journal of Open Source Software?

@mhubii
Copy link

mhubii commented Oct 5, 2024

hi @logological , currently reviewing 2 submissions already, but thank you for consideration.

@logological
Copy link

@sixpearls We've received a submission entitled "madupite: A High-Performance Distributed Solver for Large-Scale Markov Decision Processes". Would you be interested in reviewing it for the Journal of Open Source Software?

@logological
Copy link

@TimKam @sivaramambikasaran @victorapm We've received a submission entitled "madupite: A High-Performance Distributed Solver for Large-Scale Markov Decision Processes". Would you be interested in reviewing it for the Journal of Open Source Software?

@victorapm
Copy link

Thanks @logological, I can help reviewing

@logological
Copy link

Thanks, @victorapm! I'll let you know when we have enough additional reviewers to start the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ pre-review Python TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics
Projects
None yet
Development

No branches or pull requests

7 participants