-
Notifications
You must be signed in to change notification settings - Fork 247
8274893: Update java.desktop classes to use try-with-resources #3082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: pr/3081
Are you sure you want to change the base?
Conversation
Backport-of: 70c6df6be431fe11c5441986ed04040f9ec3b750
👋 Welcome back tpushkin! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
/approval request Backporting for parity with Oracle and to make a dependent in-progress backport cleaner. |
@TimPushkin |
Backport of JDK-8274893 from JDK 17, for parity with Oracle 11.0.27.
The only conflict was trivial: in imports of
JEditorPane
which uses * imports in this release, so no change was needed.Testing: GitHub CI,
jdk_imageio
test group locally (mac/arm64)Progress
Integration blocker
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3082/head:pull/3082
$ git checkout pull/3082
Update a local copy of the PR:
$ git checkout pull/3082
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3082/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3082
View PR using the GUI difftool:
$ git pr show -t 3082
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3082.diff
Using Webrev
Link to Webrev Comment