Skip to content

Conversation

TimPushkin
Copy link

@TimPushkin TimPushkin commented Aug 28, 2025

Backport of JDK-8274893 from JDK 17, for parity with Oracle 11.0.27.

The only conflict was trivial: in imports of JEditorPane which uses * imports in this release, so no change was needed.

Testing: GitHub CI, jdk_imageio test group locally (mac/arm64)


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8274893 needs maintainer approval
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Dependency #3081 must be integrated first

Issue

  • JDK-8274893: Update java.desktop classes to use try-with-resources (Enhancement - P5 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3082/head:pull/3082
$ git checkout pull/3082

Update a local copy of the PR:
$ git checkout pull/3082
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3082/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3082

View PR using the GUI difftool:
$ git pr show -t 3082

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3082.diff

Using Webrev

Link to Webrev Comment

Backport-of: 70c6df6be431fe11c5441986ed04040f9ec3b750
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 28, 2025

👋 Welcome back tpushkin! A progress list of the required criteria for merging this PR into pr/3081 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 28, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 70c6df6be431fe11c5441986ed04040f9ec3b750 8274893: Update java.desktop classes to use try-with-resources Aug 28, 2025
@openjdk
Copy link

openjdk bot commented Aug 28, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Aug 28, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 28, 2025

Webrevs

Copy link
Contributor

@alexeybakhtin alexeybakhtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@TimPushkin
Copy link
Author

/approval request Backporting for parity with Oracle and to make a dependent in-progress backport cleaner.
Low risk. The change is a cleanup limited to jdk.desktop, it should not change the behavior. It has been running in newer LTS releases for a while now. There was a single trivial conflict (imports).
Testing: GitHub CI, jdk_imageio test group locally (mac/arm64).

@openjdk
Copy link

openjdk bot commented Aug 29, 2025

@TimPushkin
8274893: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants