-
Notifications
You must be signed in to change notification settings - Fork 247
8271456: Avoid looking up standard charsets in "java.desktop" module #3081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Reviewed-by: phh Backport-of: 6b55ef3
👋 Welcome back tpushkin! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Almost clean backport with minimum trivial changes
|
JDI test failures do not seem related to the change: the change only affects #3082, which depends on this PR, passed the CI (i.e. the issue is probably intermittent), while unrelated #3077 has exactly the same issue (i.e. the issue is not related to this particular change). So I don't think anything in this PR should be fixed. |
/approval Backporting for parity with Oracle and to make dependent in-progress backports cleaner. |
@TimPushkin usage: |
/approval request Backporting for parity with Oracle and to make dependent in-progress backports cleaner. |
@TimPushkin |
Backport of JDK-8271456 from JDK 17, for parity with Oracle 11.0.26.
There were trivial conflicts in copyright years and imports in a few files.
Testing: GitHub CI,
jdk_imageio
test group locally (mac/arm64)Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3081/head:pull/3081
$ git checkout pull/3081
Update a local copy of the PR:
$ git checkout pull/3081
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3081/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3081
View PR using the GUI difftool:
$ git pr show -t 3081
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3081.diff
Using Webrev
Link to Webrev Comment