Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280132: Incorrect comparator com.sun.beans.introspect.MethodInfo.MethodOrder #2053

Closed
wants to merge 1 commit into from

Conversation

gdams
Copy link
Member

@gdams gdams commented Jul 21, 2023

Hi all,
This pull request contains a backport of commit 2f46af05 from the openjdk/jdk repository.
The commit being backported was authored by Sergey Bylokhov on 9 Feb 2022 and was reviewed by Phil Race.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8280132 needs maintainer approval

Issue

  • JDK-8280132: Incorrect comparator com.sun.beans.introspect.MethodInfo.MethodOrder (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2053/head:pull/2053
$ git checkout pull/2053

Update a local copy of the PR:
$ git checkout pull/2053
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2053/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2053

View PR using the GUI difftool:
$ git pr show -t 2053

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2053.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 21, 2023

👋 Welcome back gdams! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ef94eb7355eaf5d29fbaebc38ad5bd4bd4c18fd4 8280132: Incorrect comparator com.sun.beans.introspect.MethodInfo.MethodOrder Jul 21, 2023
@openjdk
Copy link

openjdk bot commented Jul 21, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 21, 2023

@gdams This change is no longer ready for integration - check the PR body for details.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 21, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 21, 2023

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 18, 2023

@gdams This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@openjdk
Copy link

openjdk bot commented Sep 26, 2023

⚠️ @gdams This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Sep 26, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 24, 2023

@gdams This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 21, 2023

@gdams This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant