Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280132: Incorrect comparator com.sun.beans.introspect.MethodInfo.MethodOrder #2053

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2014, 2018, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2014, 2022, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -98,10 +98,7 @@ static List<Method> get(Class<?> type) {

/**
* A comparator that defines a total order so that methods have the same
* name and identical signatures appear next to each others. The methods are
* sorted in such a way that methods which override each other will sit next
* to each other, with the overridden method last - e.g. is Integer getFoo()
* placed before Object getFoo().
* name and identical signatures appear next to each others.
**/
private static final class MethodOrder implements Comparator<Method> {

Expand Down Expand Up @@ -132,18 +129,7 @@ public int compare(final Method a, final Method b) {
}
final Class<?> aret = a.getReturnType();
final Class<?> bret = b.getReturnType();
if (aret == bret) {
return 0;
}

// Super type comes last: Integer, Number, Object
if (aret.isAssignableFrom(bret)) {
return 1;
}
if (bret.isAssignableFrom(aret)) {
return -1;
}
return aret.getName().compareTo(bret.getName());
return aret == bret ? 0 : aret.getName().compareTo(bret.getName());
}

static final MethodOrder instance = new MethodOrder();
Expand Down
Loading