Skip to content

8379156: Specify behavior of Types.asElement() on array types #30094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jddarcy wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −6
Open

8379156: Specify behavior of Types.asElement() on array types #30094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/java.compiler/share/classes/javax/lang/model/util/Types.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ public interface Types {
* Types <em>without</em> corresponding elements include:
* <ul>
* <li>{@linkplain TypeKind#isPrimitive() primitive types}
* <li>{@linkplain TypeKind#ARRAY array types}
* <li>{@linkplain TypeKind#EXECUTABLE executable types}
* <li>{@linkplain TypeKind#NONE "none"} pseudo-types
* <li>{@linkplain TypeKind#NULL null types}
Expand Down
17 changes: 11 additions & 6 deletions test/langtools/tools/javac/processing/model/util/types/TestAsElement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2023, 2026, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand All @@ -23,7 +23,7 @@

/*
* @test
* @bug 8300857
* @bug 8300857 8379156
* @summary Test Types.asElement in cases specified to return null
* @library /tools/javac/lib
* @build JavacTestingAbstractProcessor TestAsElement
Expand Down Expand Up @@ -55,18 +55,23 @@ public boolean process(Set<? extends TypeElement> annotations,
}

private void testNullCases() {
// Test all primitive types
// Test all primitive types and arrays of primitive types
for (TypeKind typeKind : TypeKind.values()) {
if (typeKind.isPrimitive() ) {
expectNullAsElement(typeUtils.getPrimitiveType(typeKind));
var primType = typeUtils.getPrimitiveType(typeKind);
expectNullAsElement(primType);
expectNullAsElement(typeUtils.getArrayType(primType));
}
}
expectNullAsElement(typeUtils.getNoType(TypeKind.VOID));
expectNullAsElement(typeUtils.getNoType(TypeKind.NONE));
expectNullAsElement(typeUtils.getNullType());

Element objectElement = eltUtils.getTypeElement("java.lang.Object");
expectNullAsElement(typeUtils.getWildcardType(objectElement.asType(), null));
Element objectElement = eltUtils.getTypeElement("java.lang.Object");
TypeMirror objectType = objectElement.asType();
expectNullAsElement(typeUtils.getWildcardType(objectType, null));
// check Object[]
expectNullAsElement(typeUtils.getArrayType(objectType));

// Loop over the ExecutableTypes for Object's methods
for(var methodElt : ElementFilter.methodsIn(objectElement.getEnclosedElements())) {
Expand Down