Skip to content

8379156: Specify behavior of Types.asElement() on array types#30094

Open
jddarcy wants to merge 1 commit intoopenjdk:masterfrom
jddarcy:JDK-8379156
Open

8379156: Specify behavior of Types.asElement() on array types#30094
jddarcy wants to merge 1 commit intoopenjdk:masterfrom
jddarcy:JDK-8379156

Conversation

@jddarcy
Copy link
Member

@jddarcy jddarcy commented Mar 5, 2026

Update the specification for Types.asElement() to cover array types. Please review the CSR as well.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8379340 to be approved

Issues

  • JDK-8379156: Specify behavior of Types.asElement() on array types (Bug - P4)
  • JDK-8379340: Specify behavior of Types.asElement() on array types (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30094/head:pull/30094
$ git checkout pull/30094

Update a local copy of the PR:
$ git checkout pull/30094
$ git pull https://git.openjdk.org/jdk.git pull/30094/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30094

View PR using the GUI difftool:
$ git pr show -t 30094

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30094.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 5, 2026

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 5, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title JDK-8379156: Specify behavior of Types.asElement() on array types 8379156: Specify behavior of Types.asElement() on array types Mar 5, 2026
@openjdk openjdk bot added csr Pull request needs approved CSR before integration compiler compiler-dev@openjdk.org labels Mar 5, 2026
@openjdk
Copy link

openjdk bot commented Mar 5, 2026

@jddarcy The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 5, 2026
@mlbridge
Copy link

mlbridge bot commented Mar 5, 2026

Webrevs

Copy link
Member

@hns hns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compiler compiler-dev@openjdk.org csr Pull request needs approved CSR before integration rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants