-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8334717: Add JVMCI support for APX EGPRs #23159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back yzheng! A progress list of the required criteria for merging this PR into |
@mur47x111 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 39 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@mur47x111 The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
@mur47x111 This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
keep alive |
@@ -55,11 +55,11 @@ public RegisterAttributes(boolean isCallerSave, boolean isCalleeSave, boolean is | |||
* @return an array whose length is the max register number in {@code registers} plus 1. An | |||
* element at index i holds the attributes of the register whose number is i. | |||
*/ | |||
public static RegisterAttributes[] createMap(RegisterConfig registerConfig, RegisterArray registers) { | |||
public static RegisterAttributes[] createMap(RegisterConfig registerConfig, List<Register> registers) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove raw arrays as much as possible in JVMCI and replace them with immutable Lists:
* @return an immutable list whose length is the max register number in {@code registers} plus 1. An
* element at index i holds the attributes of the register whose number is i.
*/
public static List<RegisterAttributes[] createMap(RegisterConfig registerConfig, List<Register> registers) {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have audited all the .clone() on array objects and changed as much as possible. Let me know if there is still some opportunity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - thanks!
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thanks for the review! |
Going to push as commit 735c789.
Your commit was automatically rebased without conflicts. |
@mur47x111 Pushed as commit 735c789. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This PR marks extra general purpose registers introduced by Intel APX as Graal allocatables. It also drops AMD64/AArch64/RISCV64.flags and RegisterArray
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23159/head:pull/23159
$ git checkout pull/23159
Update a local copy of the PR:
$ git checkout pull/23159
$ git pull https://git.openjdk.org/jdk.git pull/23159/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23159
View PR using the GUI difftool:
$ git pr show -t 23159
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23159.diff
Using Webrev
Link to Webrev Comment