Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8342646: JTREG_TEST_THREAD_FACTORY in testing.md should be TEST_THREAD_FACTORY #21594

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Oct 20, 2024

Hi all,
In make/RunTests.gmk, the keyword is 'TEST_THREAD_FACTORY'.

So the below test command will print error:

make test TEST=test/jdk/java/math/BigInteger/TestValueExact.java CONF=linux-x86_64-server-release JTREG="JTREG_TEST_THREAD_FACTORY=Virtual"
Building target 'test' in configuration 'linux-x86_64-server-release'
JTREG_TEST_THREAD_FACTORY=Virtual is not a valid keyword for JTREG.
Valid keywords: JOBS TIMEOUT_FACTOR FAILURE_HANDLER_TIMEOUT TEST_MODE ASSERT VERBOSE RETAIN TEST_THREAD_FACTORY MAX_MEM RUN_PROBLEM_LISTS RETRY_COUNT REPEAT_COUNT MAX_OUTPUT REPORT OPTIONS JAVA_OPTIONS VM_OPTIONS KEYWORDS EXTRA_PROBLEM_LISTS LAUNCHER_OPTIONS.
RunTests.gmk:206: *** Cannot continue. Stop.

So I think we should fix the document bug in doc/testing.md to avoid take the same mistake. Trivial fix, no risk.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8342646: JTREG_TEST_THREAD_FACTORY in testing.md should be TEST_THREAD_FACTORY (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21594/head:pull/21594
$ git checkout pull/21594

Update a local copy of the PR:
$ git checkout pull/21594
$ git pull https://git.openjdk.org/jdk.git pull/21594/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21594

View PR using the GUI difftool:
$ git pr show -t 21594

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21594.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 20, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 20, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 20, 2024
@openjdk
Copy link

openjdk bot commented Oct 20, 2024

@sendaoYan The following labels will be automatically applied to this pull request:

  • build
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org build build-dev@openjdk.org labels Oct 20, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 20, 2024

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org rfr Pull request is ready for review serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

1 participant