8342646: JTREG_TEST_THREAD_FACTORY in testing.md should be TEST_THREAD_FACTORY #21594
+5
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
In make/RunTests.gmk, the keyword is 'TEST_THREAD_FACTORY'.
So the below test command will print error:
So I think we should fix the document bug in
doc/testing.md
to avoid take the same mistake. Trivial fix, no risk.Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21594/head:pull/21594
$ git checkout pull/21594
Update a local copy of the PR:
$ git checkout pull/21594
$ git pull https://git.openjdk.org/jdk.git pull/21594/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 21594
View PR using the GUI difftool:
$ git pr show -t 21594
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21594.diff
Webrev
Link to Webrev Comment