8342646: JTREG_TEST_THREAD_FACTORY in testing.md should be TEST_THREAD_FACTORY

[sendaoYan]

Hi all,
In make/RunTests.gmk, the keyword is 'TEST_THREAD_FACTORY'.

So the below test command will print error:

make test TEST=test/jdk/java/math/BigInteger/TestValueExact.java CONF=linux-x86_64-server-release JTREG="JTREG_TEST_THREAD_FACTORY=Virtual"

Building target 'test' in configuration 'linux-x86_64-server-release'
JTREG_TEST_THREAD_FACTORY=Virtual is not a valid keyword for JTREG.
Valid keywords: JOBS TIMEOUT_FACTOR FAILURE_HANDLER_TIMEOUT TEST_MODE ASSERT VERBOSE RETAIN TEST_THREAD_FACTORY MAX_MEM RUN_PROBLEM_LISTS RETRY_COUNT REPEAT_COUNT MAX_OUTPUT REPORT OPTIONS JAVA_OPTIONS VM_OPTIONS KEYWORDS EXTRA_PROBLEM_LISTS LAUNCHER_OPTIONS.
RunTests.gmk:206: *** Cannot continue. Stop.

So I think we should fix the document bug in doc/testing.md to avoid take the same mistake. Trivial fix, no risk.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8342646: JTREG_TEST_THREAD_FACTORY in testing.md should be TEST_THREAD_FACTORY (Bug - P4)

Reviewers

• Magnus Ihse Bursie (@magicus - Reviewer)
• Erik Joelsson (@erikj79 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21594/head:pull/21594
$ git checkout pull/21594

Update a local copy of the PR:
$ git checkout pull/21594
$ git pull https://git.openjdk.org/jdk.git pull/21594/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21594

View PR using the GUI difftool:
$ git pr show -t 21594

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21594.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8342646: JTREG_TEST_THREAD_FACTORY in testing.md should be TEST_THREAD_FACTORY

Reviewed-by: ihse, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

• 330f2b5: 8342295: compiler/jvmci/TestJVMCISavedProperties.java fails due to garbage in output
• 1f35748: 8342102: ZGC: Optimize copy constructors in ZPhysicalMemory
• 66ddaaa: 8340241: RISC-V: Returns mispredicted
• 07f550b: 8340818: Add a new jtreg test root to test the generated documentation
• 27ef6c9: 8341470: BigDecimal.stripTrailingZeros() optimization
• 5d5d88a: 8339570: Add Tidy build support for JDK tests
• 239d84a: 8342578: GHA: RISC-V: Bootstrap using Debian snapshot is still failing
• aa060f2: 8342334: CDS: Scratch mirrors should not point to dead klasses
• 680dc5d: 8342496: C2/Shenandoah: SEGV in compiled code when running jcstress
• 8f2b23b: 8341407: C2: assert(main_limit == cl->limit() || get_ctrl(main_limit) == new_limit_ctrl) failed: wrong control for added limit
• ... and 3 more: https://git.openjdk.org/jdk/compare/309b929147e7dddfa27879ff31b1eaad271def85...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@sendaoYan The following labels will be automatically applied to this pull request:

• build
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (7c6a7bb4)
• 00: Full (f1aab5dc)

[sendaoYan]

Thanks all for the review.
/integrate

[openjdk]

Going to push as commit cdad728.
Since your change was applied there have been 49 commits pushed to the master branch:

• 018db8c: 8342809: C2 hits "assert(is_If()) failed: invalid node class: Con" during IGVN due to unhandled top
• f1f1537: 8341453: java/awt/a11y/AccessibleJTableTest.java fails in some cases where the test tables are not visible
• 476d0f1: 8339309: unused-variable warnings happen in libfontmanager
• d6eddcd: 8327624: Remove VM implementation that bypass verification for core reflection
• 28147da: 8341913: Support CDS heap dumping for Shenandoah and Epsilon
• c61d2c5: 8341445: DecimalFormatSymbols setters should throw NPE
• aafc8d0: 8342850: Change ProblemList to have LimitDirectMemory refer to JDK-8342849
• 893266c: 8342601: AArch64: Micro-optimize bit shift in copy_memory
• f9852ae: 8342839: Malformed copyright in StringNameTable since JDK-8342806
• af5e532: 8342806: Desugar capturing lambda in StringNameTable
• ... and 39 more: https://git.openjdk.org/jdk/compare/309b929147e7dddfa27879ff31b1eaad271def85...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sendaoYan Pushed as commit cdad728.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.