Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8342646: JTREG_TEST_THREAD_FACTORY in testing.md should be TEST_THREAD_FACTORY #21594

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+5 −5
Open

8342646: JTREG_TEST_THREAD_FACTORY in testing.md should be TEST_THREAD_FACTORY #21594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f1aab5d
8342646: JTREG_TEST_THREAD_FACTORY in testing.md should be TEST_THREA…
sendaoYan Oct 20, 2024
6b16d4c
Use JTREG="JTREG_TEST_THREAD_FACTORY=Virtual" to make comment more cl…
sendaoYan Oct 21, 2024
7c6a7bb
JTREG="TEST_THREAD_FACTORY=Virtual"
sendaoYan Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/testing.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,7 @@ <h4 id="failure_handler_timeout">FAILURE_HANDLER_TIMEOUT</h4>
<p>Sets the argument <code>-timeoutHandlerTimeout</code> for JTReg. The
default value is 0. This is only valid if the failure handler is
built.</p>
<h4 id="jtreg_test_thread_factory">JTREG_TEST_THREAD_FACTORY</h4>
<h4 id="test_thread_factory">TEST_THREAD_FACTORY</h4>
<p>Sets the <code>-testThreadFactory</code> for JTReg. It should be the
fully qualified classname of a class which implements
<code>java.util.concurrent.ThreadFactory</code>. One such implementation
Expand Down
2 changes: 1 addition & 1 deletion doc/testing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ Defaults to 4.
Sets the argument `-timeoutHandlerTimeout` for JTReg. The default value is 0.
This is only valid if the failure handler is built.

#### JTREG_TEST_THREAD_FACTORY
#### TEST_THREAD_FACTORY

Sets the `-testThreadFactory` for JTReg. It should be the fully qualified
classname of a class which implements `java.util.concurrent.ThreadFactory`. One
Expand Down
4 changes: 2 additions & 2 deletions test/hotspot/jtreg/vmTestbase/nsk/jvmti/GetObjectMonitorUsage/objmonusage001.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ public static int run(String argv[], PrintStream out) {
}
// Virtual threads are not supported by GetObjectMonitorUsage.
// Correct the expected values if the test is executed with
// JTREG_TEST_THREAD_FACTORY=Virtual.
// JTREG="TEST_THREAD_FACTORY=Virtual".
Thread expOwner = mainThread.isVirtual() ? null : mainThread;
int expEntryCount = mainThread.isVirtual() ? 0 : 1;

Expand Down Expand Up @@ -157,7 +157,7 @@ public objmonusage001a(Thread mt, int i, Object s) {
public void run() {
// Virtual threads are not supported by GetObjectMonitorUsage.
// Correct the expected values if the test is executed with
// JTREG_TEST_THREAD_FACTORY=Virtual.
// JTREG="TEST_THREAD_FACTORY=Virtual".
Thread expOwner = this.isVirtual() ? null : this;
Thread expNotifyWaiter = mainThread.isVirtual() ? null : mainThread;
int expEntryCount = this.isVirtual() ? 0 : 1;
Expand Down
2 changes: 1 addition & 1 deletion test/hotspot/jtreg/vmTestbase/nsk/jvmti/GetObjectMonitorUsage/objmonusage004.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public static int run(String args[], PrintStream out) {
synchronized (lockCheck) {
// Virtual threads are not supported by GetObjectMonitorUsage.
// Correct the expected values if the test is executed with
// JTREG_TEST_THREAD_FACTORY=Virtual.
// JTREG="TEST_THREAD_FACTORY=Virtual".
Thread expOwner = currThread.isVirtual() ? null : currThread;
int expEntryCount = currThread.isVirtual() ? 0 : 2;

Expand Down