Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: release v6.151.0 #7750

Merged
merged 8 commits into from
Oct 8, 2024
Merged

build: release v6.151.0 #7750

merged 8 commits into from
Oct 8, 2024

Commits on Oct 3, 2024

  1. fix(deps): bump libphonenumber-js from 1.11.9 to 1.11.10 in /shared (#…

    …7743)
    
    Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.11.9 to 1.11.10.
    - [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md)
    - [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/compare/v1.11.9...v1.11.10)
    
    ---
    updated-dependencies:
    - dependency-name: libphonenumber-js
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    2474757 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. fix(deps): bump libphonenumber-js from 1.11.10 to 1.11.11 in /shared (#…

    …7746)
    
    Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.11.10 to 1.11.11.
    - [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md)
    - [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/compare/v1.11.10...v1.11.11)
    
    ---
    updated-dependencies:
    - dependency-name: libphonenumber-js
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    daa7c07 View commit details
    Browse the repository at this point in the history
  2. chore(deps-dev): bump @types/lodash from 4.17.9 to 4.17.10 in /shared (

    …#7744)
    
    Bumps [@types/lodash](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/lodash) from 4.17.9 to 4.17.10.
    - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
    - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/lodash)
    
    ---
    updated-dependencies:
    - dependency-name: "@types/lodash"
      dependency-type: direct:development
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    cb3cce5 View commit details
    Browse the repository at this point in the history
  3. feat: migrate from CRA4 to Vite, Storybook to v8, jest to Vitest (#7285)

    * feat: add initial vite config and new eslint rules
    
    * feat: replace CRA variables with Vite variables
    
    * feat: update ts-config
    
    * feat: remove craco, fix webpack -> esbuild errors
    
    * feat: update vite config for proxy and node polyfills
    
    * feat: make decryption workers work on Vite
    
    * fix: theme typing generation script
    
    * fix: bundle worker as es
    
    * fix: update storybook to work with vite
    
    * feat: upgrade to storybook v8 package with vite builder
    
    * fix: remove deprecated turbo-build storybook addon
    
    * fix: add missing node-stdlib-browser package
    
    * feat: switch to vitest, fix storybook test invocations
    
    * feat: format and lint
    
    * feat: update msw package (to v1 latest, not v2 yet)
    
    v2 requires more changes, not worth it for now
    
    * fix: set svgr loader to not inject default dimensions
    
    * fix: regression in storybook 7 that removes 100% height from stories
    
    * fix: remove preview changes from `.storybook/main.ts`
    
    actually good to snapshot full page instead of just fixed pages
    
    * fix(test): use expect instead of just awaiting canvas.findByText
    
    * fix: flakey toast test due to multiple tests running at the same time
    
    hypothesis is that multiple toasts are rendering???
    
    * fix: modal bounding box for chromatic stories
    
    * feat: reuse old github secret env var instead of renaming to VITE_APP
    
    * feat: remove unused .builtime-env
    
    does not seem to be needed now that we use vite
    
    * fix: misrenamed import
    
    * feat: load datadog-chunk as separate script from main react app
    
    * chore: remove unused cmds, update cmds
    
    * feat: upgrade to react 18 and chakra v2 (#7292)
    
    * feat: upgrade react and chakra-ui
    react v17 -> react v18
    chakra v1 -> chakra v2
    
    * fix: breaking changes from Chakra v2
    
    * fix: use React 18
    
    * feat: update framer-motion, MotionBox instantiation
    
    * feat: update changed React.FC to FCC prop type
    
    * fix: sync all type-fest package types
    
    * fix: remove unnecessary package patches
    
    * feat: remove unnecessary scripts and script comments
    
    * fix: correctly generate chakra theme types
    
    * fix: revert motionbox back to old implementation
    
    new implementation doesn't work lol
    
    * fix: upgrade serverless type-fest to sync with rest of app
    
    * fix: use updated useToken call signature
    
    * fix: update react-joyride for React 18 compat
    
    * fix: types for allowed MyInfo types
    
    * fix: broken types assertions or code raised by linter
    
    * fix: invalid React SVG prop clip-path -> clipPath
    
    * fix: replace dnd package with React 18 compatible package
    
    * fix: update package to remove console warning about deprecated calls
    
    ReactMarkdown: Support for defaultProps will be removed from function components in a future major release.
    
    * fix: temporary fix for menu focus color desync
    
    final fix is to move to OGPDS
    
    * feat: update `@testing-library/*` packages
    
    remove unused testing-library/dom package
    
    * feat: lock storybook packages
    
    * fix: correctly upgrade virus-scanner type-fest package
    
    * fix: use `isDisabled` prop over disabled
    
    will not correctly set state if isDisabled is used instead
    
    * fix: test assertions due to RTL changes
    
    * fix: upgrade floating-ui package for compatibility
    
    * fix: compat issues in ChakraUI v2
    
    * feat: update input theming for ChakraUI v2
    
    * fix: NumberInput render
    
    * feat: update Drawer and Modal themes to have background using cssVars
    
    * fix: use explicit style context required by Chakra V2
    
    * fix: correctly import from component Button
    
    * fix: update margin due to flex using `gap` now
    
    instead of the margin-top previously, which allowed for margin collapse
    
    * fix: update Rating component spacing due to flex gap change in chakra
    
    * fix: update YesNo field margins due to Flex gap change
    
    * fix: weird margins with collaborator menu, match width
    
    * fix: use __css instead of sx for FeatureBanner
    
    or text will be space-betweened
    
    * fix: button spacing for CreateWorkspaceModal
    
    * fix: button spacing for DeleteWorkspaceModal
    
    * fix: button spacing for RenameWorkspaceModal
    
    * fix: spacing on LandingPage sections
    
    * feat: update ParagraphField story to catch multiline changes too
    
    * feat: remove unnecessary focus-visible package
    
    * feat: update `isTruncated` -> `noOfLines`
    
    * feat: fix width of PermissionDropdown for consistent widths
    
    * fix: align ViewOnlyPermission row margins
    
    * fix: SingleSelect theme breaking because of Menu
    
    really need to go to OGPDS soon lol
    
    * fix: add padding to prefill lock icon
    
    * fix: add correct msw handlers for workspace page
    
    * fix: add back missing margins
    
    * fix: make AvatarMenu have automatic height
    
    instead of following button's height
    
    * fix: add back missing menuitem padding for SingleSelect
    
    * fix: update imported lottie file type
    
    * fix: correct modal story color scheme for cancel button
    
    * fix: set minH of TagInput to input's var
    
    * fix: use input exported css variables for styling TagInput
    
    * fix: move combobox input to the top when focused
    
    so the border won't look janky
    
    * feat: use mockdate decorator so skeleton width fixed in snapshot
    
    * fix: spacing of collaborator list view again
    
    * fix: landing page margins
    
    * fix: avatarmenudivider margins
    
    * fix: remove removed patches copy in dockerfile
    
    * remove ineffective white bg on style header
    
    ---------
    
    Co-authored-by: Ken <ken@open.gov.sg>
    
    * feat: upgrade typescript to 5.4.5 across app (#7305)
    
    * feat: upgrade react and chakra-ui
    react v17 -> react v18
    chakra v1 -> chakra v2
    
    * fix: breaking changes from Chakra v2
    
    * fix: use React 18
    
    * feat: update framer-motion, MotionBox instantiation
    
    * feat: update changed React.FC to FCC prop type
    
    * fix: sync all type-fest package types
    
    * fix: remove unnecessary package patches
    
    * feat: remove unnecessary scripts and script comments
    
    * fix: correctly generate chakra theme types
    
    * fix: revert motionbox back to old implementation
    
    new implementation doesn't work lol
    
    * fix: upgrade serverless type-fest to sync with rest of app
    
    * fix: use updated useToken call signature
    
    * fix: update react-joyride for React 18 compat
    
    * fix: types for allowed MyInfo types
    
    * fix: broken types assertions or code raised by linter
    
    * fix: invalid React SVG prop clip-path -> clipPath
    
    * fix: replace dnd package with React 18 compatible package
    
    * fix: update package to remove console warning about deprecated calls
    
    ReactMarkdown: Support for defaultProps will be removed from function components in a future major release.
    
    * fix: temporary fix for menu focus color desync
    
    final fix is to move to OGPDS
    
    * feat: update `@testing-library/*` packages
    
    remove unused testing-library/dom package
    
    * feat: lock storybook packages
    
    * fix: correctly upgrade virus-scanner type-fest package
    
    * fix: use `isDisabled` prop over disabled
    
    will not correctly set state if isDisabled is used instead
    
    * fix: test assertions due to RTL changes
    
    * fix: upgrade floating-ui package for compatibility
    
    * fix: compat issues in ChakraUI v2
    
    * feat: update input theming for ChakraUI v2
    
    * fix: NumberInput render
    
    * feat: update Drawer and Modal themes to have background using cssVars
    
    * fix: use explicit style context required by Chakra V2
    
    * fix: correctly import from component Button
    
    * fix: update margin due to flex using `gap` now
    
    instead of the margin-top previously, which allowed for margin collapse
    
    * fix: update Rating component spacing due to flex gap change in chakra
    
    * fix: update YesNo field margins due to Flex gap change
    
    * fix: weird margins with collaborator menu, match width
    
    * fix: use __css instead of sx for FeatureBanner
    
    or text will be space-betweened
    
    * fix: button spacing for CreateWorkspaceModal
    
    * fix: button spacing for DeleteWorkspaceModal
    
    * fix: button spacing for RenameWorkspaceModal
    
    * fix: spacing on LandingPage sections
    
    * feat: update ParagraphField story to catch multiline changes too
    
    * feat: remove unnecessary focus-visible package
    
    * feat: update `isTruncated` -> `noOfLines`
    
    * feat: fix width of PermissionDropdown for consistent widths
    
    * fix: align ViewOnlyPermission row margins
    
    * fix: SingleSelect theme breaking because of Menu
    
    really need to go to OGPDS soon lol
    
    * fix: add padding to prefill lock icon
    
    * fix: add correct msw handlers for workspace page
    
    * fix: add back missing margins
    
    * fix: make AvatarMenu have automatic height
    
    instead of following button's height
    
    * fix: add back missing menuitem padding for SingleSelect
    
    * fix: update imported lottie file type
    
    * fix: correct modal story color scheme for cancel button
    
    * fix: set minH of TagInput to input's var
    
    * fix: use input exported css variables for styling TagInput
    
    * fix: move combobox input to the top when focused
    
    so the border won't look janky
    
    * feat: use mockdate decorator so skeleton width fixed in snapshot
    
    * fix: spacing of collaborator list view again
    
    * fix: landing page margins
    
    * fix: avatarmenudivider margins
    
    * fix: remove removed patches copy in dockerfile
    
    * remove ineffective white bg on style header
    
    * feat: upgrade typescript to 5.4.5 across app
    
    * fix: all frontend type errors after typescript upgrade
    
    * fix: backend type errors after upgrading typescript
    
    ---------
    
    Co-authored-by: Ken <ken@open.gov.sg>
    
    * fix: typing errors on setHasSingleSubmissionValidationError for preview
    
    * fix: add partialdeep typing on non-en i18n
    
    * fix: additional typing errors on stories
    
    * test: remove global playwright timeout, use individual test timeouts
    
    * fix: inifite mounting for StripePaymentContainer
    
    * refactor: remove unrendered text
    
    * fix: frm-1818 scroll lock trapping
    
    * fix: frm-1821 folder icon focus border clashing with folder text
    
    * fix: frm-1820 sharpen focus border n calendar
    
    * fix: frm-1817 insufficient padding between charts and icon
    
    * fix: ts typing, ts config, test config
    
    * fix: missing variable post-merge conflict resolution
    
    * fix: fe lint-sort
    
    * fix: circular deps warning by rollup
    
    * fix: FRM-1819 add custom detection element addon flag
    
    * try no logs
    
    * mute all logs
    
    * add missing tweetnacl module
    
    * revert test code
    
    * fix: old imports to beautiful-dnd, outdated package-lock
    
    * fix: linting issues from updated ts lib
    
    * fix: additional typing issues
    
    * fix: envvars not readable on vite builds
    
    ---------
    
    Co-authored-by: Ken <ken@open.gov.sg>
    karrui and KenLSM authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    d5d43d8 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #7748 from opengovsg/release-al2

    build: merge release v6.150.0 to develop
    KenLSM authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    cbc4456 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #7753 from opengovsg/release-al2

    build: merge release v6.150.1 to develop
    kevin9foong authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    7fcc581 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. fix: regression on dropdown input, workflow save action step component (

    #7754)
    
    * fix: dropdown input regression
    
    * fix: flakey dates on Billing page
    
    * fix: remove addition margin, chakra v2 likely fixed the margin gap problem on dividers
    KenLSM authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    4b11c69 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8b5bdc6 View commit details
    Browse the repository at this point in the history