fix: regression on dropdown input, workflow save action step component #7754
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KenLSM
changed the title
KenLSM
added a commit
that referenced
this pull request
Oct 8, 2024
#7754) * fix: dropdown input regression * fix: flakey dates on Billing page * fix: remove addition margin, chakra v2 likely fixed the margin gap problem on dividers
KenLSM
added a commit
that referenced
this pull request
Oct 8, 2024
#7754) * fix: dropdown input regression * fix: flakey dates on Billing page * fix: remove addition margin, chakra v2 likely fixed the margin gap problem on dividers
KenLSM
added a commit
that referenced
this pull request
Oct 10, 2024
* fix: regression on dropdown input, workflow save action step component (#7754) * fix: dropdown input regression * fix: flakey dates on Billing page * fix: remove addition margin, chakra v2 likely fixed the margin gap problem on dividers * chore: replace zonedTimeToUtc to fromZonedTime * fix: ts errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Regression introduced from react migration that was detected from Chromatic.
Solution
mtthat is no longer required as dividers now properly provide margins.hasInputRightElementprops to accommodate right element spacing.Breaking Changes