-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Bugfix assimp addons #8288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix assimp addons #8288
Conversation
… libs paths for assimp addons closes openframeworks#8273
|
with this change a similar change in PG is needed. |
|
@dimitre yeah - I think its an edge case just of ofxAssimp as its relying on libs from ofxAssimpModelLoader. PG solves this with So it needs this set: Anyway yeah, probably best not to rely on the wild card. The main issue is there is so much code in apothecary now doing the sub folder stuff it would be a lot of work to revert, so I just make the smallest possible fix now. probably better to just have: |
|
@dimitre the wildcard pattern also fixes OpenCV But again, this could be switched to WASM or this section could be removed and picked up by the folder parser. |
|
need the extra folder to support WASM64 as well, there is two targets Nice |
|
again not using subfolders was the root cause of the issue |
closes #8273
this PR allows for % wildcard patterns for libs which weren't supported before in makefiles.
so this now works:
ADDON_LIBS=../ofxAssimpModelLoader/libs/assimp/lib/emscripten/%/libassimp.a